Comments (4)
This could be a good idea to explore indeed.
I guess it would go like this: if Commit#extract_candidates decides to fallback to the commit author, and the email is already present in the commits table, return the canonical name assigned to that one.
The only gotcha that comes to mind is that a few emails like "[email protected]" map to two contributors. But these are known so maybe we could workaround that.
Would you like to work on it?
from rails-contributors.
Actually it might be more complicated. The application does not know which heuristic was applied to the existing commit. For example, the commit could have a hard-coded rule to be associated to someone else, or the commit message could have overriden the author, or the commit could have several authors associated. In those cases this check won't yield a correct association.
from rails-contributors.
I have seen more counterexamples.
For example the email "[email protected]" has as authors "Akira Matsuda", "Akira Matsuda + Koichi Sasada", "Akira Matsuda & Yukiko Kawamoto", "Akira Matsuda & Kohei Suzuki", "Akira Matsuda & saya", "Akira Matsuda & Naoto Koshikawa". The email "[email protected]" maps to "Sean Griffin", and also to "@schneems and @sgrif".
There are quite a few examples of email addresses from which you cannot automatically assign a canonical name.
I think this is trickier that it seems, by now the app is going to keep ignoring emails and work only based on names.
from rails-contributors.
Fair enough, thanks for looking into it.
from rails-contributors.
Related Issues (14)
- Issue with commits of abhishek shown against Abhishek yadav HOT 4
- Improper name mapping HOT 6
- Some commits are missing in the list HOT 25
- Change CI service HOT 5
- Can we redeploy with updated aliases? HOT 1
- Understand Co-Authored-By HOT 4
- Split contributions issue HOT 2
- Missing HTTPS on rails-contributors link HOT 1
- Issue with alkesh26 commits shown against alkeshghorpade HOT 3
- Build failures related to mimemagic 0.3.5
- Contributors API
- Contradictory FAQ Text HOT 3
- Restore the commits credited to Jean-François Labbé HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rails-contributors.