Code Monkey home page Code Monkey logo

Comments (4)

fxn avatar fxn commented on June 26, 2024

This could be a good idea to explore indeed.

I guess it would go like this: if Commit#extract_candidates decides to fallback to the commit author, and the email is already present in the commits table, return the canonical name assigned to that one.

The only gotcha that comes to mind is that a few emails like "[email protected]" map to two contributors. But these are known so maybe we could workaround that.

Would you like to work on it?

from rails-contributors.

fxn avatar fxn commented on June 26, 2024

Actually it might be more complicated. The application does not know which heuristic was applied to the existing commit. For example, the commit could have a hard-coded rule to be associated to someone else, or the commit message could have overriden the author, or the commit could have several authors associated. In those cases this check won't yield a correct association.

from rails-contributors.

fxn avatar fxn commented on June 26, 2024

I have seen more counterexamples.

For example the email "[email protected]" has as authors "Akira Matsuda", "Akira Matsuda + Koichi Sasada", "Akira Matsuda & Yukiko Kawamoto", "Akira Matsuda & Kohei Suzuki", "Akira Matsuda & saya", "Akira Matsuda & Naoto Koshikawa". The email "[email protected]" maps to "Sean Griffin", and also to "@schneems and @sgrif".

There are quite a few examples of email addresses from which you cannot automatically assign a canonical name.

I think this is trickier that it seems, by now the app is going to keep ignoring emails and work only based on names.

from rails-contributors.

connorshea avatar connorshea commented on June 26, 2024

Fair enough, thanks for looking into it.

from rails-contributors.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.