Comments (5)
Here's an example of this issue in action:
irb(main):015:0> Tutorial.find("R-SKC ").id
=> "R-SKC "
irb(main):019:0> Tutorial.find("R-SKC ").to_global_id.to_s
=> "gid://tenjin/Tutorial/R-SKC "
irb(main):020:0> GlobalID.parse("gid://tenjin/Tutorial/R-SKC ")
=> nil
from globalid.
I'm not sure how common this is. Does overriding to_global_id
in your model work? You'd probably need a custom locator to whip the model id back into shape.
from globalid.
@kaspth needing to support trailing spaces might be an edge case, but that's what encoding schemes are for.
AIUI, we're currently insisting (well, assuming) that all identifiers contain only characters that are safe unescaped in a URL path segment. Are we deriving some benefit from that restriction, beyond not having to call a method? 😕
from globalid.
@kaspth I think this is less a case of 'trailing spaces are weird, why would anybody need that' and more a case of the fact that ActiveRecord supports a far wider range of values as IDs than GlobalID. It would be nice to fix that.
Also, for the majority of cases, urlencoding the ID should be backwards compatible.
from globalid.
@matthewd @thomasfedb Sorry for being slow here. You're both right, and Active Record supporting many more types of ids is why we should fix this.
@thomasfedb would you be interested in opening a PR? 😄
from globalid.
Related Issues (20)
- Error while trying to deserialize arguments: uninitialized constant GlobalID::Locator HOT 10
- expires_in does not work in initializer properly
- Test failed with rails 5.2 HOT 1
- New release please? HOT 2
- Test failures HOT 1
- expires_in does not work HOT 1
- Cannot globally default to non-expiring ids by setting config.global_id.expires_in to nil
- What are some potential ways to misuse signed Global IDs? HOT 1
- [Suggestion] Allow different primary_ids such as UUID HOT 5
- [Suggestion] Add support for eager loading optionally HOT 4
- Preferred way to check if a Signed GlobalID is expired? HOT 4
- Raise error on unknown options HOT 7
- Is there a way to limit how many times a sgid can be used? HOT 1
- Bug or breaking change? Model class must now implement `.primary_key` HOT 9
- SignedGlobalID: Consider re-adding the ability to use the old serialization format HOT 1
- Consider adding a request-specific expires_at HOT 1
- Idea: Locating embedded resources
- Efficient Object Parsing: Redis-Based Global Object Management for Model ID-Independent Operations
- ActionText::Richtext attachments are broken after upgrading to 1.2.0 HOT 1
- Custom locator raises NameError when class name not defined HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from globalid.