Comments (1)
Looks like the attachments are not necessarily broken. ActionText is able to find the attachment records with either of the sgid
s.
The issue is with how we implemented the serialisation and rendering of the rich text. We serialise the attachments separately from the ActionText::Richtext body and match them the sgid
in the richtext with the sgid
of the separately serialised objects. The objects are serialised with ActionText::Attachable#attachable_sgid
.
All the attachments that were attached before v1.2.0 are using the previous sgid
in the rich text and the serialised objects are returning a newer sgid
s. Therefore, our frontend couldn't match them to render appropriately.
I would like to understand why this is happening and if we can make ActionText::Attachable#attachable_sgid
to return the old format?
--
For those who might land here, I managed to update the references in the richtext by running the following to update all the attachments in rich text.
require_relative "config/environment"
updated_attachments = []
ActionText::RichText.where.not(body: nil).find_each do |trix|
next unless trix.body.attachments.size.positive?
trix.body.fragment.find_all("action-text-attachment").each do |node|
attachment = ActionText::Attachment.from_node(node)
next if !attachment.attachable.is_a?(SectionItem)
puts "attachment: #{attachment}"
if node.attributes["sgid"].value != attachment.attachable_sgid
updated_attachments << [
trix.id,
node.attributes["sgid"].value,
attachment.attachable_sgid, # new sgid
attachment.attachable.class.name,
attachment.attachable.id,
]
end
node.attributes["sgid"].value = attachment.attachable_sgid
end
trix.update_column :body, trix.body.to_s
end
File.open("updated_attachments.csv", "w") do |f|
f.puts "trix_id,old_sgid,new_sgid,attachable_type,attachable_id"
updated_attachments.each { |row| f.puts(row.join(",")) }
end
from globalid.
Related Issues (20)
- Error while trying to deserialize arguments: uninitialized constant GlobalID::Locator HOT 10
- expires_in does not work in initializer properly
- Test failed with rails 5.2 HOT 1
- New release please? HOT 2
- Test failures HOT 1
- expires_in does not work HOT 1
- Cannot globally default to non-expiring ids by setting config.global_id.expires_in to nil
- What are some potential ways to misuse signed Global IDs? HOT 1
- [Suggestion] Allow different primary_ids such as UUID HOT 5
- [Suggestion] Add support for eager loading optionally HOT 4
- Preferred way to check if a Signed GlobalID is expired? HOT 4
- Raise error on unknown options HOT 7
- Is there a way to limit how many times a sgid can be used? HOT 1
- Bug or breaking change? Model class must now implement `.primary_key` HOT 9
- SignedGlobalID: Consider re-adding the ability to use the old serialization format HOT 1
- Consider adding a request-specific expires_at HOT 1
- Idea: Locating embedded resources
- Efficient Object Parsing: Redis-Based Global Object Management for Model ID-Independent Operations
- Custom locator raises NameError when class name not defined HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from globalid.