Add Resque 2 adapter about activejob HOT 6 CLOSED

I will try to do this one too.

from activejob.

@seuros any updates on this?
I was thinking about this and I saw 3 possible solutions:

1. At the beginning of the test/helper.rb have a system "AJADAPTER=#{ENV['AJADAPTER']} bundle update resque" and in the Gemfile load resque gem depending on the AJADAPTER. (We will probably have to remove the Gemfile.lock from the repo also)
2. Create a separate Gemfile.resque2. At the begining of test/helper.rbset BUNDLE_GEMFILE to Gemfile or Gemfile.resque2 based on AJADAPTER value
3. Use appraisal

from activejob.

I added appraisal for now and changed the rake script, i can commit this change if you want.

The problem is that if you switch just the gem, the test will pass. That mean that the tests are not well writing, i'm going to make them fail first by using a real database instead of the fake ORM.

from activejob.

Well the problem I saw with appraisal was that when running the whole test suite (aka rake test) they all should pass and I don't see that possible with appraisal. So ideally:

• if I run rake test it should run all tests (the resque2 test should run with resque 2.x gem) and pass
• if I run an individual test it should run that test (with the correct gem version for resque)

I would go with Gemfile.resque2...

from activejob.

Here's what I had in mind: https://github.com/cristianbica/activejob/compare/resque2
Main issue with the implementation is that when updating developement gems you need to run bundle && BUNDLE_GEMFILE="Gemfile.resque1" bundle and BUNDLE_GEMFILE="Gemfile.resque2" bundle
Also the resque2 is in heavy development and stuff aren't working (Resque.inline, resque-scheduler). I suggest we wait for them to have a more stable version ready and then work on an adapter.

from activejob.

👍 to waiting until a stable version is out.

from activejob.