Convert resque-statsd to activejob-statsd about activejob HOT 9 CLOSED

I will try to do it, since i already started in similar gem yesterday.

from activejob.

@dhh, i nearly finished this task, need to rewrite tests from rspec to minitest and the configuration module.

from activejob.

Sweet! 👍

On May 25, 2014, at 1:22 PM, Abdelkader Boudih [email protected] wrote:

@dhh, i nearly finished this task, need to rewrite tests from rspec to minitest and the configuration module.

—
Reply to this email directly or view it on GitHub.

from activejob.

WIP : https://github.com/seuros/activejob-stats
It is working.

from activejob.

Great stuff! Even better as a generic plugin. I’ll add specific notes tomorrow.

On May 25, 2014, at 6:30 PM, Abdelkader Boudih [email protected] wrote:

WIP : https://github.com/seuros/activejob-stats
It is working.

—
Reply to this email directly or view it on GitHub.

from activejob.

I'd love to see activejobs support statsd out of the box. I don't have a problem with an alternative gem providing plugins for other APIs or data stores but statsd is so widely accepted that Rails making an opinionated choice here seems ok.

from activejob.

Not everybody want/need stats for their jobs and statsd require special installation of nodejs/python and configuring apache/nginx . I think it better to keep AJ as described in it's description.
Also for example when I'm going to use Sidekiq, i won't need any statsd server since Sidekiq provide this feature already.

from activejob.

1. Statsd is a simple protocol. statsite is a C impl and statsdaemon is a Go impl. Both Librato and Datadog, commercial stats SaaSs, support the statsd protocol out of the box. No Node.js, python, nginx or apache config required.
2. I'm not suggesting it be mandatory - just pass something that quacks the statsd-ruby API and it'll activate, e.g.:

config.active_jobs.stats_reporter = MySQLStatsd.new

from activejob.

I agree with @seuros that this is better served in a separate gem. We don't ship any request statistics in ActionPack either. Not every app is going to run at such a level of operational efficiency that these stats are going to be meaningful.

We should, however, encourage the use of this gem in the README for AJ. So there's a clear, official answer to this. Just not included by default.

from activejob.