raid-guild / character-sheets-contracts Goto Github PK

• To avoid doing two transactions on the frontend, the eligibility modules should wrap minting of a new hat with addEligibleAddresses
• https://github.com/raid-guild/character-sheets-contracts/blob/main/src/adaptors/hats-modules/AdminHatEligibilityModule.sol#L119

• Remove all burn XP calls, except for functions that are meant to be used as an emergency
• Emergency class burning should include burning class-XP (Refer #32)

if certain items are used for crafting then they are transferred to the items manager.
Then if the player dismantled those crafter items there is a possibility of the user obtaining item that amounts to more than the distribution.

• Add a address => classId => xpBalance mapping to the class contract, so that XP can be associated with a particular class
• A mintXP function should be added to the class contract, which updates the balance of the class-XP mapping, and also mints the existing ERC-20 XP
• If class-based XP passes a level threshold, an additional class NFT should be minted (thus leveling up that class)

If an item requirement doesn't originate from the items/classes/exp contracts don't transfer it to our contracts, only check that the required balance is held by the account.

• Being added to an additional game requires passing the game's existing eligibility check
• If they pass, they would receive a player hat, and their character would receive a character hat
• Note that XP, classes, and items between games will remain separate

• Even after transferring their character, a player is unable to create a new one (the function call reverts)
• It's also not possible for the new player of the character to transfer it back to the old player