raharrison / kotlin-ktor-exposed-starter Goto Github PK

Currently suspend on the incoming channel until exception is thrown.

Logs get cluttered with exceptions from Netty every time socket is closed

Also, shouldn't the newSuspendedTransaction {} block in DatabaseFactory be using Dispatchers.IO? That's how JetBrains does it in the Ktor docs.

Mostly, I'm just wondering why you would want Hikari set to isAutoCommit = false.

Thanks!

the port configuration is hard-coded, and the application.conf is ignored.
The following code would fix the issue

 embeddedServer(Netty, commandLineEnvironment(args)).start(wait = true)

application.conf:    
ktor {
    deployment {
        port = 8000
        watch = [  build ] 
    }

    application {
        modules = [ MainKt.mainModule ]
    }
}

• Test service using in-memory db
• Test endpoints via RestAssured

Need to be in same running instance

Recent Kotlin versions have Coroutine IO (CIO) library. Do you think it's reasonable to migrate netty to CIO for this starter?

import org.jetbrains.exposed.sql.Table
unresolved reference:exposed.....
i have compile exposed successful like this: compile "org.jetbrains.exposed:exposed:0.10.4"

Hey @raharrison ,

this is probably a question only a total Kotlin newbie can ask- I do it anyway :)
I'm looking at different ktor example projects to learn its structure, and while I can start most of them with ./gradlew run it seems I can't start yours. Can you let me know what I'm doing wrong?
I tried to find some explanation in the README. So once I get it to run I'm happy to provide a PR against your README (in case I didn't just miss the explanation).

My assumption is that I can run the service somehow- is run the correct command?

Here's what's going wrong:

tuhlmann:~/.../kotlin/kotlin-ktor-exposed-starter$ ./gradlew run
> Task :run FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':run'.
> No main class specified and classpath is not an executable jar.

Thanks,
Torsten.

Would you mind to add support of Flyway or Liquibase?