ragona / quorum Goto Github PK
View Code? Open in Web Editor NEWQuorum is a CLI that generates Shamir key shares, and encrypts/decrypts data using elliptic curve integrated encryption scheme with AES-GCM.
Quorum is a CLI that generates Shamir key shares, and encrypts/decrypts data using elliptic curve integrated encryption scheme with AES-GCM.
Is it worth adding additional metadata in the output container? With the current construction I think you can successfully mix and match shares from different quorums to accidentally produce novel 'secrets'. Even just putting a shared random 32bit value in the container as a quorum tag and checking at decrypt
-time that they're all the same would prevent this.
I tested this locally and because you're using authenticated encryption you're not getting random spew on the output, but it's a fairly unsatisfying: Error: Failed to decrypt ciphertext: ring::error::Unspecified
Line 25 in 618aad2
One thing that strikes me as potentially useful for a tool like this is the ability to encrypt a value to the quorum without having to assemble the quorum, which potentially increases the exposure of the key material. If you generated instead an ed25519 private key and Shamir split it and also output the public key then you could encrypt to the quorum without needing the key assembled.
I can also see the argument that needing quorum to create sealed values is a feature.
Line 66 in 618aad2
This is an unhelpful issue, it's just philosophizing around decision decisions you've already made. Sorry!
Checking quorum v0.1.0 (/home/gkelly/p/quorum)
error: pub(crate) function inside private module
--> src/encrypt.rs:12:1
|
12 | pub(crate) fn encrypt(args: &Encrypt) -> Result<()> {
| ----------^^^^^^^^^^^
| |
| help: consider using: `pub`
|
note: the lint level is defined here
--> src/main.rs:3:9
|
3 | #![deny(clippy::nursery)]
| ^^^^^^^^^^^^^^^
= note: `#[deny(clippy::redundant_pub_crate)]` implied by `#[deny(clippy::nursery)]`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate
error: pub(crate) function inside private module
--> src/encrypt.rs:34:1
|
34 | pub(crate) fn decrypt(args: &Decrypt) -> Result<()> {
| ----------^^^^^^^^^^^
| |
| help: consider using: `pub`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate
error: pub(crate) function inside private module
--> src/quorum.rs:9:1
|
9 | pub(crate) fn generate(args: &Generate) -> Result<()> {
| ----------^^^^^^^^^^^^
| |
| help: consider using: `pub`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate
error: pub(crate) function inside private module
--> src/quorum.rs:36:1
|
36 | pub(crate) fn recover_secret(share_paths: Vec<String>, threshold: u8) -> Result<[u8; 32]> {
| ----------^^^^^^^^^^^^^^^^^^
| |
| help: consider using: `pub`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pub_crate
error: could not compile `quorum` due to 4 previous errors
Right now if you recover bad shares it'll fail with an unhelpful message.
Right now the name is always quorum.pub
and quorum_share_{}.priv
. Add optional argument for naming these.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.