rafsanjani / blizzard Goto Github PK

It looks like one of your previous PRs made a change to the database schema and forgot to update the version number. @tonyez

Fragments do not restore their state when user navigates, e, a navigation such as home ->favorites->home will completely restart the whole app flow and load weather for current city instead of retaining weather info for whatever city was searched.

As it stands now, all searches are saved to the database and displayed in the favorites tab. Add a favorite button to the weather info card so that user's can favorite particular searches or unfavorite them if they have previously been added to favorites.

The errors from the methods fetching the weather are getting consumed completely in the viewmodel without any reflection on the UI, leaving it in a loading state forever. One way of doing this is to use a Kotlin sealed class to represent the state of the app.

The animation in the home fragment is too slow. UI animations should typically be between 100 - 200ms so that they don't distract user experience. @lokaimoma

This information showed in the notification is incorrect

The time from the api isn't accurate and doesn't update when a query made earlier is been made again. Any ideas on how to solve this.
Togo is one hour behind Morocco, but the time shown is wrong.

Currently the way data is loaded into the views are quiet similar.
Is it a good idea to set up one view model to deal with populating
data into the views

And for the location permission, the permission is asked right after
the app is installed, i don't know if it is ideal to do it that way,
if no, then how best and when should the permission be
asked for.

The connection state is shown too many times. Let's modify it so that it only shows when a network request is in progress and also only when there is no network.