Code Monkey home page Code Monkey logo

share-preview's Introduction

share-preview's People

Contributors

albanobattistella avatar atalanttore avatar bertob avatar combicraft avatar danik2343 avatar emintufan avatar flipflop97 avatar fnogcps avatar gnu-ewm avatar jouaux avatar kianmeng avatar mejans avatar milotype avatar pervoj avatar rafaelmardojai avatar rafal06 avatar rene-coty avatar sabriunal avatar santossi avatar sebinnyshkim avatar tcitworld avatar transifex-integration[bot] avatar vistaus avatar weblate avatar weslley75 avatar wjt avatar xfgusta avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

share-preview's Issues

App Icon

We need a proper icon to release a first version.

Refresh button to ask the selected site to clear the cache?

Social media sites' built-in share preview tools typically cache their opengraph previews, particularly images, but there usually is a button to force them to refresh / fetch the latest version. This is useful if you are actively working on improving the metadata on a website and are testing things with trial and error.

Would it be possible for this app to plug into those APIs to provide a Refresh button (when available)? If the refresh has a cooldown time limit for a particular site, the button could have a label (or GtkTooltip) that indicates that cooldown in real time while the button is in GTK "insensitive" status.

Discord event banners

The Discord chatting app supports scheduling events with fancy banners, have a look:

obfuscated banner 1

obfuscated banner 2

Is this a good fit for Share Preview?

Increase margins around headerbar

The top part of the window looks a bit cramped, I'd increase margins around and below the headerbar.

For example, here I added 6px on all sides, plus 6px top margin on the content:

image

Remember my last selection

  1. Select Twitter from the list
  2. Type some address and look at the preview
  3. Quit
  4. Reopen

Expected: It should remember my last selection and default to it.

Actual: It always reset to Facebook (the topmost selection.)

Version 0.2.0 via Flathub.

Doap file missing

A share-preview.doap file is missing. Note that it has to have the same name/capitalization as the GitHub repository.

For the maintainer to appear in Apps for gnome it must be in the form

  <maintainer>
    <foaf:Person>
      <foaf:name>User Name</foaf:name>
      <foaf:mbox rdf:resource="mailto:[email protected]" />
      <gnome:userid>gnome-user-acc</gnome:userid>
      <foaf:account>
        <foaf:OnlineAccount>
            <foaf:accountServiceHomepage rdf:resource="https://github.com/"/>
            <foaf:accountName>user-github-acc</foaf:accountName>
        </foaf:OnlineAccount>
      </foaf:account>
    </foaf:Person>
  </maintainer>

Dark toggle button should not remain active

The dark toggle button is currently inactive when in light mode, and active when in dark mode. That's a bit weird IMO, since the two views are semantically at the same level.

A potential alternative could be what Icon Library does, where the button doesn't stick but the icon changes between a filled and an outline sun.

Enter key focuses the wrong widget after pasting with the mouse

If you copy some URL and, instead of using Ctrl+V, you paste it into the URL field by doing "Right-click -> Paste", the GtkTextEntry will be defocused, and when you hit Enter:

  • If there was no existing preview, nothing will happen.
  • If there was an existing preview, the "Details" (currently a spyglass icon thingy) button below the preview will be activated, opening the details instead of launching the query.

Totally a corner case, but I thought I'd report it anyway ;)

Discourse forums preview

I don't know if there's a way to simulate this too, but it would be pretty nice to be able to preview what a link may look like when shared on a Discourse forum, because the way it previews tends to be very different from the rest of social media, and it has progressively become the most popular modern open source forum software (and that's what GNOME uses for its forums, like many other communities use nowadays).

Preview for Signal

Nice application!

For some reason the preview for https://www.eicas.nl currently doesn't load in the Signal desktop app. It would be really helpful if share-preview could detect what's wrong.

(earlier I found out the Signal desktop app doesn't load preview images for which the HTTP response doesn't have a Content-Length header - I haven't checked what's wrong this time yet)

Warn users using relative URLs on Twitter

Share Preview seems to display images with relative URLs, although Twitter does not support this.

Notice that the image isn't shown.

On Share Preview, it looks like this:

Where it shows the image.


As a solution, I'd make it warn the user when the website is using relative path, rather than a URL.

The spyglasss button is confusing

“Hm. There’s a search field at the bottom of the dialog. I wonder what it does. Oh, it shows more details and not search.”

Please consider picking a different icon (the circled i for information, perhaps) or just spell out “Details” or “<meta>” instead?

Version 0.2.0 via Flathub.

Mastodon account for this project

Would a Mastodon account be possible for this project?

The following things could then run on it:

  • Project information
  • Project announcements
  • Interaction with the Fediverse community

Download image

I would love to see an option to download the image from a preview link. It could be in the files tab but would be more useful on the main page with the preview.

og:image previews fail for WebP images

Facebook, Reddit (#12), and Twitter supports WebP images in og:image (and twitter:image), but the app shows an o-slash icon instead.

It’s probably correct to show the o-slash and a warning for Mastadon as support varies depending on the ImageMagic version installed on each server instance (upstream issue #14983).

Crashes when trying to preview https://cockpit-project.org/

I get a crash every time when I try to preview https://cockpit-project.org/ or one of its blog posts, such as https://cockpit-project.org/blog/cockpit-244.html

I'm not sure if something is just wildly wrong with what I'm doing on website or if I just happen to triggering an issue in Share Preview. (Either way, Share Preview shouldn't crash.)

And also: thanks for this app! It looks very useful. I'm looking forward to finally fixing cockpit-project/cockpit-project.github.io#224 (it's been on my TODO backburner for quite some time), thanks to Share Preview.

Crash on beta.flathub.org possibly due to webp

Tried to fix up a banner for flathub new site and my trusty tool is crashing :)

$ flatpak run com.rafaelmardojai.SharePreview

(share-preview:2): Gtk-WARNING **: 09:59:55.354: GtkText - did not receive a focus-out event.
If you handle this event, you must return
GDK_EVENT_PROPAGATE so the default handler
gets the event as well
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Unsupported(UnsupportedError { format: Exact(WebP), kind: GenericFeature("VP8L") })', src/backend/image.rs:51:85
stack backtrace:
   0:     0x55776793a3bc - <unknown>
   1:     0x55776795f6cc - <unknown>
   2:     0x557767933663 - <unknown>
   3:     0x55776793cce2 - <unknown>
   4:     0x55776793c8c5 - <unknown>
   5:     0x55776793d333 - <unknown>
   6:     0x55776793d050 - <unknown>
   7:     0x55776793a864 - <unknown>
   8:     0x55776793cd89 - <unknown>
   9:     0x557767696571 - <unknown>
  10:     0x557767696663 - <unknown>
  11:     0x5577677193c4 - <unknown>
  12:     0x55776791b96f - <unknown>
  13:     0x55776791c9fa - <unknown>
  14:     0x7fa52d400cdb - g_main_context_dispatch
  15:     0x7fa52d4011e8 - <unknown>
  16:     0x7fa52d4012b4 - g_main_context_iteration
  17:     0x7fa52d5de3ed - g_application_run
  18:     0x5577676990f3 - <unknown>
  19:     0x5577676e3458 - <unknown>
  20:     0x5577676eb3a3 - <unknown>
  21:     0x55776772fac9 - <unknown>
  22:     0x557767939a70 - <unknown>
  23:     0x5577676eb6a2 - <unknown>
  24:     0x7fa52d0a1b80 - __libc_start_main
  25:     0x557767696d3e - <unknown>

Support for messenger previews

I think messenger previews would be a good addition to share-preview

Signal
image

WhatsApp (don't remember it always being so bland, tried with different links but all look the same)
image

Translation platform

Please decide upon the translation platforms: Hosted Weblate or Transifex!

Recently I got emails about Transifex notifications, but there is just one file: share-preview_po-share-preview-pot--master_en.po. There are no translated languages!

On the other hand most translations exist at Hosted Weblate, which you specify in the section Translations of the ReadMe.md file.

My suggestion:
Get rid of Transifex! IMO, Hosted Weblate is better anyhow.

Cheers,
Milo

The text entry needs a clear button

People have been steadily requesting keyboard shortcuts and other typing enhancements, but I wanted to go the other way.

When the text entry field is filled with a URL, there's no way to clear it quickly and easily with the mouse (no, Context menu → Select All; Context Menu → Delete does not count as quick and easy), should one wish to restore the initial blank canvas in preparation for future URL typing/pasting.

Something like Qt's QLineEdit.clearButtonEnabled, which automatically shows a clear icon at the end of the input area whenever it's non-empty, would be cool. Of course, GtkEntry doesn't seem to have anything quite so convenient, and you're already using that part of the widget to display the "Go"/"Submit" button... 🤷‍♂️

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.