rafaelblink / angular-custom-checkbox Goto Github PK

Hello @rafaelblink,

I was looking to your library but I am facing an issue at build time.
I am using Angular 6 and I think you have to update your package ;)

Stacktrace :
ng build --aot

ERROR in angular-custom-checkbox\angular-custom-checkbox.ts(6,2): Error during template compile of 'CustomCheckboxModule' Function calls are not supported in decorators but 'ɵmakeDecorator' was called in 'NgModule' 'NgModule' calls 'ɵmakeDecorator'. node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'. node_modules/angular-custom-checkbox/node_modules/@angular/core/src/render3/ng_dev_mode.d.ts(9,11): error TS2451: Cannot redeclare block-scoped variable 'ngDevMode'.

Will you update your package in a near future ?

Kind regards,

David

Hello,

I've come across your package looking for a reference for creating my custom checkbox component and I saw this method:

setDisabledState ? (isDisabled: boolean) : void {}

which comes from the ControlValueAccessor interface.
I'm not at all proficient in Typescript but if I understand correctly the question mark after the method name in an interface specifies that the method does not have to be implemented in a concrete class using that interface. Your class is a concrete class and you provided the method with a body(empty body but still). I'm having trouble figuring out what this question mark does in this specific scenario and I would much appreciate an explanation.

Thanks in advance.

Write in documentation about import of pretty-checkbox(SCSS and pure CSS) and import formsModule of Angular.