radbuilder / emojichat Goto Github PK

Would it be possible to add a hook for ChatControl Pro to allow emojis to work?
https://www.spigotmc.org/resources/%E2%99%A3-chatcontrol-pro%E2%84%A2-format-and-filter-your-chat-1-7-10-1-15-1-holiday-sale.10258/

ChatControl formatting doesn't seem to allow emojis to be replaced via their shortcut or their long name (i.e. :smile:). If I use commands such as Essential's /me or Essential's /msg to message myself, I can see the emoji fine. I can also see the emojis on signs perfectly fine. It's just typing in chat publicly, emojis do not appear or get replaced.

My ChatControl formatting is fairly simple.

  Chat:
    Player:
      Message: '{display_name}&f: '
      Hover_Event:
        Action: SHOW_TEXT
        Values:
        - '{player}'
    The_Rest:
      Message: '{message}'

Using ChatControl's admin chat channel command /chatcontrol ach test message :confused: shows the emoji fine in that chat channel. Again, it's just public chat that doesn't seem to display anything. :(

What steps will reproduce the issue?

1. Install the plugin with the latest PAPI

What was supposed to happen?

[Response]
Emojis happen

What happened instead?

[Response]
No Emojis

What Spigot version are you using?

Full /version output

What plugins do you have installed?

Full /plugins output
Not relevent

Are any errors related to EmojiChat in your console or logs? If so, paste below.

paste
error(s)
here

Any additional information that you would like to provide that may be relevant to the issue?

[Response]
Placeholder API pushed an update that means the old api it provided no longer works and must be updated to the new changes

What do you think should be added/changed?

1.18 Support

Any additional information that you would like to provide that would be helpful/relevant?

DiscordSRV v1.19.0-SNAPSHOT
EmojiChat v1.8.3

When you use the heart emoji :heart: on discord, in-game displays an extra trailing symbol when it is translated. Other emojis seem to display fine.

Image courtesy of Andre_601 from Spigot forums.

The compatibility with DiscordSRV is great, but it would be cool if you could import the minecraft emoji into discord.

What steps will reproduce the issue?

1. write Korean.(가, 나, 다 ...)

What was supposed to happen?

I write Korean!

What happened instead?

가 = 💯 / 공 = 🐉 / 건 = 🙏 etc...(There are others, but I'll skip them.)

What Spigot version are you using? Paste the output of /version below.

This server is running CraftBukkit version git-Spigot-7754231-362ed32 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

What plugins do you have installed? Paste the output of /plugins below.

TreysDoubleJump, SuperElytra, WorldEdit, PlayerPanels, TranslatorAPI, InventoryFullPlus, GoldBigDragonRPG, Calculator, Mention, ProtocolLib, WorldGuard, EpicBoss-Updated-Edition, TTranslateChat, SignEdit, ChatItem, AlwaysElytra, VoxelSniper, EffectLib, ParticleLIB, Vault, ArmorWeight, MCRealisticPlus, Essentials, BKCommonLib, GadgetsMenu, SignLink, Maplands, VariableTriggers, Citizens, DiscordSRV, EmojiChat, EssentialsSpawn

Are any errors related to EmojiChat in your console or logs? If so, paste below.

nothing.

Any additional information that you would like to provide that may be relevant to the issue?

There are two Korean plug-ins!
And Im Korean!(I can't speak English.)

What steps will reproduce the issue?

Enter any emoticon shortcut ( 😄, 😁, and so on) and search in GUI.

What was supposed to happen?

Emoticon should appear in chat, emoticons should appear in GUI.

What happened instead?

All emoticons are chinese letters.

What Spigot version are you using? Paste the output of /version below.

[06:03:05 INFO]: This server is running CraftBukkit version git-Spigot-7862817-bd30843 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)
[06:03:05 INFO]: Checking version, please wait...
[06:03:06 INFO]: You are running the latest version

What plugins do you have installed? Paste the output of /plugins below.

Plugins (70): PlaceholderAPI, Vehicles, DeluxeCommands, Thirst, SimpleAPI, InfoBook, Actionbar, Titlebar, LuckPerms, BandageCraft, AnimatedScoreboard, BetterRealismPro, ProtocolLib, Multiverse-Core, MVdWPlaceholderAPI, AutoRespawnPlus, FastAsyncWorldEdit, SpoilerAlert, VoidGenerator, EmojiChat, Tab, Multiverse-Portals, LuckPermsMVdWHook, ServerListPlus, Vault, BetterDrops, MassiveCore, Gender, BKCommonLib, Rankup, SignLink, DabCore, CreativeGates, Maplands, HolographicDisplays, StreetlightsAdvanced, Multiverse-SignPortals, EpicWorldGenerator, Multiverse-NetherPortals, TreeFeller, MassiveBooks, PerPlayerBlood, EpicNetherGenerator, Bank, WorldEdit, Essentials, AnimatedNames, LightCleaner, RPGHealthPlus, Train_Carts, EssentialsChat, UltimateBackpacks, WorldGuard, TCActionBlocks, WorldSchematics2, EssentialsAntiBuild, EssentialsSpawn, CorpseReborn, Jobs, ExtraContexts, SimplePets, Citizens, Sentinel, GriefPrevention, CitizensText, Builder, Quests, Blacksmith, Alchemist, MelonCrack

Are any errors related to EmojiChat in your console or logs? If so, paste below.

No errors appear in console and logs.

Any additional information that you would like to provide that may be relevant to the issue?

Minecraft needs extremely long to start and login into my server when using emoji resourcepack.

Here's a video from the issue: https://youtu.be/fMSeNL2pEb8

Hello, I'm not using your plugin but do you know if mojang fix the issue with glyph_sizes.bin to make it compatible with 64*64 font ?

These special charachters doesn't work and look like a chineese charachters.

What do you think should be added/changed?

Chat handling should be updated, to perhaps utilize the JSON chat option (BaseComponent system) as this introduced full unicode-support and options to display custom fonts within Minecraft 1.16.

Any additional information that you would like to provide that would be helpful/relevant?

As mentioned did MC 1.16 add support for various things within their JSON text, which are notably custom colors (Any HEX color) and custom fonts, that could be used WITHIN the same message with a separate font. I've put an example image from Slicedlime's info video about the technical changes of MC 1.16 below.

This essentially means that you would no longer need to override specific fonts through a resource pack that could make it unusable for people using that particular language.
Instead could you now just add an additional font type to the server with a resource pack that would add the emojis through this.

The only downside I can currently see with this would be, that you have to use JSON text here and can't just have normal chat in return.
But a (perhaps) benefit could be to have hover text for the emoji, that would display the emoji name, which would be a small but nice addition.
Another (minor?) disadvantage would be that this is only available in 1.16 and therefore not backwards compatible. Additionally do I not know how plugins like ViaVersion with ViaBackwards or ProtocolSupport would handle this custom font and what would be the output for clients that join with older versions like 1.15.2 on a 1.16 server.

Those are just some suggestions and ideas I had in mind and wanted to bring up here.

Hello!

We've recently found this plugin, and it rocks! We were considering using this plugin, however it seems like this plugin is outdated, and doesn't have the newer emojis..

Any chance we can get a documentation on how to add them? I'm willing to mess around with the code, however I'd like some guidance with the resource pack creation..

Thanks!

1.20.4 Support please add emojis show as null characters within chat, the resource pack shows as incompatible please update

On discord if you type :), the smiley emoji does not show in-game. It outputs as :slightly_smiling: text while EmojiChat's actual smiley is slightly_smiling_face. The weird thing is while it outputs as :slightly_smiling: text in-game, when you hover over the emoji on discord, it's actually called :slight_smile:.

I tried adding both as shortcuts to the config, but smiling on discord does not translate to the emoji.

shortcuts:
  slightly_smiling_face:
  - ':)'
  - '(:'
  - ':slightly_smiling:'
  - ':slight_smile:'

Other emojis work fine to and from discord and in-game. Would it be possible to add an alias to match discord's emoji name so smiling on discord works?

Using DiscordSRV to bridge chat.

DiscordSRV v1.19.0-SNAPSHOT
EmojiChat v1.8.3

DiscordSRV v1.19.0-SNAPSHOT
EmojiChat v1.8.3

# If you're using chat color plugins, this will remove the coloring for emojis to be displayed correctly.
fix-emoji-coloring: true

Emoji colors do not seem to get fixed when this setting is enabled. Tested with Essentials and ChatControlPro. Tried using Essentials' /me and /msg command with formatting being a different color by default (i.e. gray for /me) and ChatControl commands with color codes. The emoji retained the chat line's color.

Why do some Chinese characters become emoticons

What steps will reproduce the issue?

Start Server and look at console

What was supposed to happen?

Legacy Material Support to not be initialised

What happened instead?

Legacy Material Support was initialised

What Spigot version are you using?

[19:48:14] [Server thread/INFO]: This server is running Paper version git-Paper-372 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)
[19:48:14] [Server thread/INFO]: Checking version, please wait...
[19:48:14] [Thread-91/INFO]: Previous version: git-Paper-350 (MC: 1.15.2)
[19:48:14] [Thread-91/INFO]: You are running the latest version

What plugins do you have installed?

[19:49:43] [Server thread/INFO]: Plugins (48): ActionAnnouncer, ActionHealth*, AdvancedReplay*, ClearLag, ConsoleSpamFix, CoreProtect, DiscordSRV, dynmap*, EmojiChat*, ExploitFixer, Factions, floodgate-bukkit, Geyser-Bukkit, GraceLite, GSit, GtzDoors, HamsterAPI*, HolographicDisplays, IllegalStack, Inventory*, InventoryRollback, KeepChunks, Lasso, LuckPerms, Maintenance, MassiveCore, Matrix, MSG*, Multiverse-Core, Multiverse-Inventories, Multiverse-NetherPortals, Multiverse-Portals, Multiverse-SignPortals, NoAFKFishing*, OpenInv, PetMaster, PlaceholderAPI, PlayerReport, ProtocolLib, RandomItemDrop*, Shopkeepers, SinglePlayerSleep, SuperVanish, UltimateHealAndFeed*, ViaBackwards, ViaVersion, WorldEdit, WorldGuard

Are any errors related to EmojiChat in your console or logs? If so, paste below.

[Server thread/WARN]: Initializing Legacy Material Support. Unless you have legacy plugins and/or data this is a bug!
[Server thread/WARN]: Legacy plugin EmojiChat v1.8.3 does not specify an api-version.

Any additional information that you would like to provide that may be relevant to the issue?

N/A

What do you think should be added/changed?

Adding an option to deny the download of the resource pack altogether, meaning that the /emojichat resourcepack would also be disabled.

Any additional information that you would like to provide that would be helpful/relevant?

Some server owners may use merged resource packs (multiple ones combined into one) to use multiple plugins which apply Resource packs, without having conflicts.
That said would EmojiChat still cause minor issues, even if you disable the automatic download on join.
Players would just need to execute /emojichat resourcepack to then override the one set by the server owner.

Upload new tag of file texturpack. the pack.mcmeta need to change of "pack_format to 18" this supports of 1.20.2 ver.

This not really hard and just update the url of plugin. For when i try upload the new url what supports pack_format 18 not allowing to download i think this API error or this a some lock that pep can't modift it!

What steps will reproduce the issue?

1. Type : grinning : in Minecraft's chat or send a message through Discord SRV containing a standard emote.

What was supposed to happen?

Emojis were supposed to display in the chat like this "😀" when you type ": grinning :" for example.

What happened instead?

You get characters like this

But they show up on Discord correctly.

What Spigot version are you using?

[19:34:29 INFO]: This server is running Paper version git-Paper-226 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
[19:34:29 INFO]: Checking version, please wait...
[19:34:29 INFO]: Previous version: git-Paper-209 (MC: 1.14.4)
[19:34:29 INFO]: You are running the latest version

What plugins do you have installed?

[19:35:13 INFO]: Plugins (20): BannerBoard*, ChopTree3, CleanroomGenerator*, CMI, DiscordSRV, EasyBackup, EmojiChat, LagMonitor*, Minecord*, Multiverse-Core, Multiverse-Inventories, Multiverse-NetherPortals, ProtocolLib, Residence, SelectionVisualizer, ServerListPlus*, UltraCustomizer, UltraPermissions, Vault*, WorldEdit

Are any errors related to EmojiChat in your console or logs? If so, paste below.

[19:28:13 ERROR]: Could not pass event AsyncPlayerChatEvent to CMI v8.6.15.6
java.lang.NoSuchMethodError: github.scarsz.discordsrv.DiscordSRV.getMainTextChannel()Lgithub/scarsz/discordsrv/dependencies/jda/core/entities/TextChannel;
        at com.Zrips.CMI.Modules.DiscordSRV.DiscordSRVManager.sendDiscordMessage(DiscordSRVManager.java:45) ~[?:?]
        at com.Zrips.CMI.Modules.NickName.NickNameListener.AsyncPlayerChatEventExtra(NickNameListener.java:170) ~[?:?]
        at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor416.execute(Unknown Source) ~[?:?]        at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.14.4.jar:git-Paper-226]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[patched_1.14.4.jar:git-Paper-226]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.14.4.jar:git-Paper-226]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:545) ~[patched_1.14.4.jar:git-Paper-226]
        at net.minecraft.server.v1_14_R1.PlayerConnection.chat(PlayerConnection.java:1713) ~[patched_1.14.4.jar:git-Paper-226]
        at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:1628) ~[patched_1.14.4.jar:git-Paper-226]
        at net.minecraft.server.v1_14_R1.PacketPlayInChat$1.run(PacketPlayInChat.java:41) ~[patched_1.14.4.jar:git-Paper-226]
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_231]
        at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_231]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source) [?:1.8.0_231]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) [?:1.8.0_231]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_231]

When will this fix be released?
I really like this plugin but i have a swedish server, so we cant type åäö.
Hope for a fix soon!

What do you think should be added/changed?

I'm not sure how possible this is, but I assume you send a sort of download request to the joining player including a link for the client?

In that case, wouldn't it be possible, to enable an option that allows downloading a different RP, if the user has a specific lang set (i.e. Chinese or Korean)?
I think this could be a potential solution for showing emojis instead of text.

Any additional information that you would like to provide that would be helpful/relevant?

Changed to github.scarsz.discordsrv.dependencies.emoji.EmojiParser;

i.e. DiscordSRV/Staff-Chat@39597f8

[23:42:33] [Server thread/ERROR]: Could not pass event DiscordStaffChatMessageEvent to EmojiChat v1.8.3
[23:42:33] [Server thread/ERROR]: Suspected Plugins: 
[23:42:33] [Server thread/ERROR]: 	EmojiChat{enabled,ver=1.8.3,path=plugins/EmojiChat.jar}
[23:42:33] [Server thread/ERROR]: 	DiscordSRV-Staff-Chat{enabled,ver=1.3.3,path=plugins/DiscordSRV-Staff-Chat-1.3.3.jar}
[23:42:33] [Server thread/ERROR]: Exception details below: 
java.lang.NoClassDefFoundError: com/vdurmont/emoji/EmojiParser
	at io.github.radbuilder.emojichat.hooks.DiscordSrvStaffChatHook.onDiscordStaffChat(DiscordSrvStaffChatHook.java:45) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor908.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:76) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:611) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at com.rezzedup.discordsrv.staffchat.util.Events.call(Events.java:12) ~[?:?]
	at com.rezzedup.discordsrv.staffchat.StaffChatPlugin.submitMessageFromDiscord(StaffChatPlugin.java:179) ~[?:?]
	at com.rezzedup.discordsrv.staffchat.listeners.DiscordStaffChatListener.lambda$onDiscordChat$0(DiscordStaffChatListener.java:22) ~[?:?]
	at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftTask.run(CraftTask.java:99) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at org.bukkit.craftbukkit.v1_16_R3.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:469) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at net.minecraft.server.v1_16_R3.MinecraftServer.b(MinecraftServer.java:1386) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:397) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1295) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:1016) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:176) ~[1.16.5-patched.jar:git-Yatopia-update/upstream-"08567c2"]
	at java.lang.Thread.run(Thread.java:832) [?:?]

EmojiChat v1.8.3

Typing a link in chat such as https://www.example.com replaces the text to https\://www.example.com.

What do you think should be added/changed?

I think the addition of 👍 and 👎 would be useful (I'm biased, it's one of my most frequently used Emojis)

Any additional information that you would like to provide that would be helpful/relevant?

N/a

What steps will reproduce the issue?

1. Set your Language to "Deutsch (Deutschland)"
2. Write or look at words containing ä, ü or ö (There may even be more but I didn't check)

What was supposed to happen?

Text should still display as normal. For example the item "Eichenholzfalltür" (oak trapdoor).

What happened instead?

The characters are changed into weird other characters instead.

What Spigot version are you using?

[14:18:31 INFO]: This server is running Paper version git-Paper-238 (MC: 1.14.4) (Implementing API version 1.14.4-R0.1-SNAPSHOT)
[14:18:31 INFO]: Checking version, please wait...
[14:18:31 INFO]: Previous version: git-Paper-236 (MC: 1.14.4)
[14:18:31 INFO]: You are running the latest version

What plugins do you have installed?

AdvancedTabOverlay*, Animatronics*, ArmorStandTools, BKCommonLib, BlockParty, BuildBattlePro, CinematicUI, DeluxeChat, DeluxePlugins*, DiscordSRV, EasterEggs, EmojiChat*, Essentials, EssentialsSpawn, Gloss*, HeadDatabase*, HelpPagePlus, InfoHeads, LightAPI*, LuckPerms, Maplands, MessageAnnouncer, MiniaturePets*, Mortar*, OpenAudioMc, PlaceholderAPI, ProtocolLib, QuickShop, ServerListPlus, SlimeWorldManager, SurveyPlus*, Vault, WarpSystem, WorldEdit, WorldGuard

Are any errors related to EmojiChat in your console or logs? If so, paste below.

no errors

Any additional information that you would like to provide that may be relevant to the issue?

https://hastebin.com/tifujatiko.js

EmojiChat 1.8.3
Paper dev 147 (Spigot 1.16.2)

What steps will reproduce the issue?

1. Add shortcuts.
2. Try to use shortcuts.
3. Don't get desired shortcuts.

Tried typing >:) in chat.

What was supposed to happen?

😈 should appear instead of 🙂

What happened instead?

🙂 appears.

Are any errors related to EmojiChat in your console or logs? If so, paste below.

None.

Any additional information that you would like to provide that may be relevant to the issue?

shortcuts:
  slightly_smiling_face:
  - ':)'
  - '(:'
  - ':slightly_smiling:'
  - ':slight_smile:'
  smiling_imp:
  - '>:)'

What do you think should be added/changed?

Adding SQL database support for remembering player's chosen toggle state when using /emojichat toggle. This resets every time the server restarts.

Checking event.getView().getTitle() to see whether your custom inventory is being used is unsafe, as renaming a chest in an anvil allows users to set their own inventory titles. The correct way to check if your custom inventory is involved with an event is by using custom holders, see here: https://docs.papermc.io/paper/dev/custom-inventory-holder