Optimization of Rack::Utils.escape_html about rack HOT 3 CLOSED

In browsing through the rails code to see if there were a similar opportunity I found that they are using the same escape algorithm in their ERB::Util module: http://github.com/rails/rails/blob/master/activesupport/lib/active_support/core_ext/string/output_safety.rb

I noticed the only entities they escape are [&"><] whereas rack also escapes apostrophes. Does anyone know if apostrophes are necessary? If they are not, this patch removes them from escape_html bahuvrihi/rack@a35e40c764a0030367b9c7cd13bd6aff88fd016a

from rack.

Thank you, I've taken your first patch as starting point and did some benchmarking, turns out it's only around 3.5 times faster on my machine.
On 1.9 compatible Ruby it could be even faster using string.to_s.gsub(/[&<>'"]/, HASH), but we have to keep the code compatible with 1.8.
I'm not going to alter the set of characters being escaped, as people may rely on it already.
I pushed the change here:
http://github.com/rack/rack/commit/b4d0dc76b2d0b8b4b7160b689ecb

from rack.

You're welcome. Thanks for the 1.9 syntax -- I didn't know about that variation.

As an FYI I'm going to open another issue regarding the escaping as I found a recommendation to escape not only apostrophe but slash as well. I won't be miffed if you close it immediately; I thought it would be good to have a separate record of it for future reference.

from rack.