Comments (5)
For reference, the Lint check was added in caed808
I think the Lint check was added so that apps/middleware that were using HTTP_VERSION as an alias to SERVER_PROTOCOL don't get client-provided information that they might use incorrectly. Maybe that Lint check can be removed? Servers that want to support both Rack 2 and 3 should do: env['SERVER_PROTOCOL'] || env['HTTP_VERSION']
from rack.
@jeremyevans are you proposing to remove caed808#diff-2db485952a203ded9d5ae1301e35d82601b1c2410f914e767b02c4933b7e8a57R302-R305
If so, I'm also okay with that.
from rack.
I think such a lint may still have value, as it pointed me to (maybe) fix Thin:
Thin was blindly overwriting curl -H 'Version: foo' http://1.2.3.4
with the value at the end of the HTTP request line instead of allowing HTTP_VERSION
to be foo
.
from rack.
@jeremyevans are you proposing to remove caed808#diff-2db485952a203ded9d5ae1301e35d82601b1c2410f914e767b02c4933b7e8a57R302-R305
If so, I'm also okay with that.
Yep, I think that can be removed. Servers should not have to deal with request Version
headers specially.
from rack.
Thin was blindly overwriting curl -H 'Version: foo' http://1.2.3.4 with the value at the end of the HTTP request line instead of allowing HTTP_VERSION to be foo.
IMHO, HTTP_VERSION
should not be set by the server going forward. I'll add a rack-conform
test for this.
As we merged #2154 I believe this issue is resolved, but feel free to re-open it if not.
from rack.
Related Issues (20)
- Nested parameters parsing error in rack 3.0.8 HOT 22
- Cookie being created with [" prefixed to name versions 3.0 thru 3.0.8 HOT 7
- Support for `Partitioned` cookie attribute HOT 16
- can't rackup HOT 5
- Rack::Lint::LintError: Status must be >=100 seen as integer HOT 10
- How to manually decode a Rack::Session::Cookie 2023 HOT 1
- 3.0.8 Multipart PATCH requests fail in minitest(Rack::Multipart::EmptyContentError) HOT 2
- Spec ambiguity: environment instance HOT 11
- undefined method `[]' for nil:NilClass HOT 1
- Multiple writes to Rack::Response result in incorrect content-length header in Rack 3 HOT 4
- 3.0.9 not visible in releases nor changelog HOT 2
- RACK_INPUT not rewound on form data HOT 2
- Upgrading from rack ~> 2.2 to >= 3.0.0 required me to do a new request.body.rewind before a request.body.read HOT 2
- Rack v2.2.8 release and changelog is missing HOT 2
- how to listen host Loopback HOT 2
- Request for release - EOFError on empty multipart request HOT 6
- Support for zstd in Deflater HOT 5
- Discrepancy in the parsing behavior of Rack::Multipart between versions 1.6 and 2.2 HOT 8
- Deprecation should note how to fix HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rack.