raccoons-rise-up / client-unity Goto Github PK

View Code? Open in Web Editor NEW

5.0 2.0 1.0 4.12 MB

Game client. This is no longer being used.

Home Page: https://discord.gg/cDNf8ja

License: GNU General Public License v3.0

C# 100.00%

rpg rpg-game unity unity-3d unity-2d csharp enet mmo mmorpg game

client-unity's People

Contributors

Stargazers

Watchers

Forkers

bmjoy

client-unity's Issues

Console Warning: Same Warnings Appear Everytime on Build

These warnings appear everytime when building the client.

Tree Steepness Calculation Always Outputting Zero

Issue

Always outputs zero meaning trees can even spawn on cliffs which is unwanted behavior.

Expected

This should output steepness values between 0 and 90

https://github.com/Kittens-Rise-Up/client/blob/24807008e3075ef1c8f2ac20fef0f8db24fc484f/Assets/Scripts/Game/Planet/PlanetRenderer.cs#L76

Communicating Between 2 Threads

The client has 2 threads, the unity thread and the enet thread. ENet must run on its own separate thread otherwise it will clog up the unity thread. The need for doing Unity related things during ENet specific events like when a packet has been received or a connection event occurs has risen.

Consider the following code to communicate from enet thread to unity thread.

public class UnityInstruction 
{
    public UnityInstructionOpcode Opcode { get; set; }
    public List<object> Data { get; set; }

    public UnityInstruction(UnityInstructionOpcode opcode) 
    {
        Opcode = opcode;
        Data = new List<object>();
    }

    public void Write(object obj) 
    {
        Data.Add(obj);
    }
}

public enum UnityInstructionOpcode
{
    LoadSceneForDisconnectTimeout,
    LoadMainScene,
    LogMessage,
    ServerResponseMessage,
    NotifyUserOfTimeout,
    UpdateGoldText,
    LoginSuccess
}

// ENet Thread
var instruction = new UnityInstruction(UnityInstructionOpcode.ServerResponseMessage);
instruction.Write($"Version mismatch. Server ver. {serverVersion} Client ver. {clientVersion}");

unityInstructions.Enqueue(instruction);

// Unity Thread
while (unityInstructions.TryDequeue(out UnityInstruction result)) 
{
    switch (result.Opcode) 
    {
        case UnityInstructionOpcode.ServerResponseMessage:
            loginScript.loginFeedbackText.text = (string)result.Data[0];
            break;
    }
}

The above works just fine. My question is, is there a better way about doing this?

UpdateUI Coroutine Does Not Start Again

Steps to Reproduce

Connect client to server (notice the message spam of the number 100 in console)
Stop server
Wait for the client to timeout to the login screen
Start server
Login the client
Notice the UILoop isn't running now (notice the message spam of the number 100 is no longer being logged)

Question about Unity Input and ENet Thread Safety

Since ENet is generally said not to be thread safe, should Peer be defined in the scope of the ENet thread worker? If this is the case how would one do peer.Send(...) inside Unity's Update() loop? Below can be seen the current method for using peer.Send(...) as one defined Peer outside the scope of the thread worker.

https://github.com/Kittens-Rise-Up/client/blob/5bf0b7ab36ff53b09e5eb3fbb2aec008158cccc5/Assets/Scripts/ENetClient.cs#L22

https://github.com/Kittens-Rise-Up/client/blob/5bf0b7ab36ff53b09e5eb3fbb2aec008158cccc5/Assets/Scripts/ENetClient.cs#L105-L112

https://github.com/Kittens-Rise-Up/client/blob/5bf0b7ab36ff53b09e5eb3fbb2aec008158cccc5/Assets/Scripts/ENetClient.cs#L114-L120

UI: Terminal Output Issues / QoL Requests

Dragging

You can only drag the terminal output vertically if you are grabbing the text. You should be able to grab from anywhere and move the terminal output up and down.

Snap to Bottom

If you drag the terminal output up, it will not snap back to the bottom as this has not been implemented yet.

How do you make transparent materials in HDRP?

Console Warning: Failed to load XML documentation

Sometimes this warning pops up in the console, I have no idea why.

Failed to load XML documentation:
System.Threading.ThreadAbortException
  at System.Xml.XmlTextReaderImpl+NodeData.SetNamedNode (System.Xml.XmlNodeType type, System.String localName, System.String prefix, System.String nameWPrefix) [0x00007] in <0f9699188f0c414ea6fb5557f5c16d15>:0 
  at System.Xml.XmlTextReaderImpl.AddAttribute (System.String localName, System.String prefix, System.String nameWPrefix) [0x0001e] in <0f9699188f0c414ea6fb5557f5c16d15>:0 
  at System.Xml.XmlTextReaderImpl.AddAttribute (System.Int32 endNamePos, System.Int32 colonPos) [0x0003b] in <0f9699188f0c414ea6fb5557f5c16d15>:0 
  at System.Xml.XmlTextReaderImpl.ParseAttributes () [0x00263] in <0f9699188f0c414ea6fb5557f5c16d15>:0 
  at System.Xml.XmlTextReaderImpl.ParseElement () [0x001df] in <0f9699188f0c414ea6fb5557f5c16d15>:0 
  at System.Xml.XmlTextReaderImpl.ParseElementContent () [0x0016f] in <0f9699188f0c414ea6fb5557f5c16d15>:0 
  at System.Xml.XmlTextReaderImpl.Read () [0x00085] in <0f9699188f0c414ea6fb5557f5c16d15>:0 
  at System.Xml.Linq.XContainer.ReadContentFrom (System.Xml.XmlReader r) [0x00201] in <a9ef27d60e3144519c0741b6584ba229>:0 
  at System.Xml.Linq.XContainer.ReadContentFrom (System.Xml.XmlReader r, System.Xml.Linq.LoadOptions o) [0x00005] in <a9ef27d60e3144519c0741b6584ba229>:0 
  at System.Xml.Linq.XDocument.Load (System.Xml.XmlReader reader, System.Xml.Linq.LoadOptions options) [0x00080] in <a9ef27d60e3144519c0741b6584ba229>:0 
  at System.Xml.Linq.XDocument.Load (System.String uri, System.Xml.Linq.LoadOptions options) [0x0000f] in <a9ef27d60e3144519c0741b6584ba229>:0 
  at System.Xml.Linq.XDocument.Load (System.String uri) [0x00000] in <a9ef27d60e3144519c0741b6584ba229>:0 
  at Unity.VisualScripting.XmlDocumentation.GetDocumentationUncached (System.Reflection.Assembly assembly) [0x00094] in C:\Users\VALK-DESKTOP\Documents\Unity Projects\Kittens Rise Up\client\Library\PackageCache\[email protected]\Editor\VisualScripting.Core\Documentation\XmlDocumentation.cs:132 
UnityEngine.Debug:LogWarning (object)
Unity.VisualScripting.XmlDocumentation:GetDocumentationUncached (System.Reflection.Assembly) (at Library/PackageCache/[email protected]/Editor/VisualScripting.Core/Documentation/XmlDocumentation.cs:136)
Unity.VisualScripting.XmlDocumentation:BackgroundWork () (at Library/PackageCache/[email protected]/Editor/VisualScripting.Core/Documentation/XmlDocumentation.cs:49)
System.Reflection.MethodBase:Invoke (object,object[])
Unity.VisualScripting.BackgroundWorker/<>c__DisplayClass0_0:<.cctor>b__3 () (at Library/PackageCache/[email protected]/Editor/VisualScripting.Core/Threading/BackgroundWorker.cs:82)
Unity.VisualScripting.BackgroundWorker:Work () (at Library/PackageCache/[email protected]/Editor/VisualScripting.Core/Threading/BackgroundWorker.cs:157)
System.Threading.ThreadHelper:ThreadStart ()

UILoop Coroutine Does Not End on Timeout to Server

The UILoop coroutine should be stopped when the player times out from the server.

The client player gold / other simulation values should be reset as well.

The terminal feedback window should be cleared as well.

Thinking of Redoing Planet Code from Scratch

Because it could be better.

Planet Water Looks Terrible

Communicating Dynamic Data Lengths Between 2 Threads

A need for communicating data with unpredictable length has risen.

I need to be able to send gold and structureHut data or sometimes just gold or sometimes just structureHut data alone. This will get even messier when new resources and structures are added in the future.

Solution 1

Data looks like the following...

opcode, data, opcode, data, opcode, data, ....

Each opcode describes what each data is in the list.

Solution 2

Data looks like the following...

opcode, data, data, data
opcode, data, data
opcode, data, data, data, data

This solution would require many combinations of opcodes. For e.g. goldHut if wanting to send data info about gold and huts or gold opcode if just wanting to send data about gold. This is really messy.

UI: text_ServerResponse width is not dynamic

text_ServerResponse width is set to 600, ideally this should be set dynamically so it fills the entire screen however the Vertical Layout Group component is constantly resetting the anchor preset to the top left. (text_ServerResponse should retain its position in the vertical layout while stretching its width to the full monitor width)

raccoons-rise-up / client-unity Goto Github PK

client-unity's People

Contributors

Stargazers

Watchers

Forkers

client-unity's Issues

Issue

Expected

Steps to Reproduce

Dragging

Snap to Bottom

Solution 1

Solution 2

Recommend Projects

Recommend Topics

Recommend Org