rabwill / generic-target-audience Goto Github PK

#3

Promise.race is used in TargetAudience.tsx

       Promise.race(proms).then(val => {
            this.setState({ canView: true }); //atleast one promise resolved
        });

But according to this Promise.race() method returns a promise that fulfills or rejects as soon as one of the promises in an iterable fulfills or rejects, with the value or reason from that promise.
So if multiple groups are passed and user is member of any one of the passed groups but some other group's API call is rejected first, canView will remain false and user won't be able to see the content.

Hi,

Thanks a lot for this project.
I am facing an issue where the values in the people picker field of the property pane are not getting stored after I publish it to the page.
Any help is highly appreciated.

Thanks