rabobank / ret-plugins Goto Github PK

As I am creating the GitHub implementation, I'm finding multiple flaws in the current interfaces which makes certain things impossible.
Therefor I would like to propose some changes. I figured this could be a place for discussion.

In my opinion we can already merge the first PR (decouple from Azure DevOps) whenever you approve, and then we can follow it up with one that contains the outcome of this discussion. I think it will keep the changes clearer and the PRs smaller.

Summary

I've checked which current interface methods are compatible with GitHub and which aren't. I've added proposed solutions for the latter. At the bottom I've wrote down what I think about how to handle singular versus multiple Git implementations.

GitProvider interface

GitUrlFactory interface

Selecting multiple providers per command or not

In general I think that for most of the list commands (autocompletion) we should combine the results of both GitProviders (if they are configured).
For actions (create PR, open URL), we should of course open the target from the right GitProvider. For this, we would need to improve the autogeneration keys to include the git provider and the repository name: ret git pr open github/users-api/136274
If at a later stage we would support multiple implementations per provider, we could extend this to github/<org>/users-api/136274.

After pressing enter Alfred closes without opening the URL to Splunk. Expected a new tab.

Currently it's only possible to add projects to the Splunk plugin's configuration by hand. There is also no link between an index and a project.

{
  "base_url" : "https://where.splunk.lives",
  "app" : "app",
  "indexes" : "index1, index2",
  "search_field" : "app-name",
  "projects" : [ {
    "name" : "project-1"
  }, {
    "name" : "project-2"
  } ],
  "plugin_version" : "0.2.0"
}