Code Monkey home page Code Monkey logo

moving_platform's Introduction

Moving_Platform

moving_platform's People

Contributors

joepieler avatar crisvdn avatar jasperoosterbroek avatar verae98 avatar thepatman3 avatar b9a9s9 avatar streefje1996 avatar gerritvanos avatar jesperobb avatar howtoprogrambirds avatar official12345 avatar ramonvbemmel avatar

Watchers

James Cloos avatar Arno Kamphuis avatar Nicky van Steensel van der Aa avatar Brian van der Bijl avatar avatar Patrick Dekker avatar

moving_platform's Issues

PR to master

There are commits from the previous sprint in release. This should have been PR'ed to master at the end of the sprint. Could you create this PR?

Function body in HPP

We've realised that there something has slipped through the code review to master.

Namely, the function body of the constructor and of the process function is in the header file instead of the source file.

The offending code can be found here:

moving_platform/code/headers/moving_platform.hpp

Lines 16 to 48 in 05d9e33

moving_platform_c(base_comm_c &comm) : base_module_c(comm) {
comm.listen_for_frames({r2d2::frame_type::MOVEMENT_CONTROL});
}
/**
* @brief
* This function will process the frames from the canbus. only reads
* from canbus
*/
void process() override {
comm.request(r2d2::frame_type::MOVEMENT_CONTROL);
while (comm.has_data()) {
auto frame = comm.get_data();
// Process the frame
// Don't handle requests
if (frame.request) {
continue;
}
const auto data =
frame.as_frame_type<frame_type::MOVEMENT_CONTROL>();
if (data.brake) {
set_speed(0);
break;
} else {
set_speed(data.speed);
turn(data.rotation);
}
}
}

We'd like to see hotfix that places the body of these functions into the respective cpp file.

Sorry for the inconvencience as this should have been noticed during the code-review to master.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.