qwazywabbitwos / lmctf60 Goto Github PK

There is a bug in skin selection on initial connect of new clients. It loops several times, choosing skin/model causing a delay on connection and a stutter of motion once the client has spawned.

Well, the VS solution is named gravity and it would seem to have a gravity bug:
If a players Z location is greater than zero the gravity suddenly decides to push the player to the roof of the map instead of keeping him on the ground. You can get back onto the ground and stick to it if you hook down to a floor that has a negative Z location and hold there until the residual velocity decays to zero. The offending lines are in ClientThink beginning at line 2731 and look like this:

	//client->ps.pmove.gravity = sv_gravity->value;
	//-DM
	//if(ent->s.origin[1] > 0)
	if(ent->s.origin[2] > 0) //gaia
		client->ps.pmove.gravity = -800;
	else
		client->ps.pmove.gravity = 800;

I don't know who gaia is/was but dude, this is some really funky modding. :)
I'm going to leave it in, just in case someone wants funky gravity in what is supposed to be an otherwise normal LMCTF mod. If you're that kind of admin and you want your players to have fun bumping their heads on the ceiling of your maps then add WANT_FUNKY_GRAVITY to your preprocessor defines and recompile. No need to comment out the line preceding the twiddle, you're not going to gain anything but a fraction of a nanosecond.

When I'm building this on Linux, I get this error now:

#24 0.868 g_save.c:9:10: fatal error: GitRevisionInfo.h: No such file or directory
#24 0.868     9 | #include "GitRevisionInfo.h"
#24 0.868       |          ^~~~~~~~~~~~~~~~~~~

Looks like this was added in commit 5031b04. I see that in g_local.h this include is guarded to only occur on Windows so probably something similar needs to be done in g_save.c.

I'm also assuming the makefile should be passing REV and VER as LMCTF_REVISION and LMCTF_VERSION definitions? Alternatively, it shouldn't be difficult to add a makefile step that just builds GitRevisionInfo.h using sed or whatever to fill in those variables in the template you defined and then you could just unconditionally include that.