quinot / choparp Goto Github PK

Since IP addresses/ranges are excluded with the same character as standard
options (dash, '-'), GNU getopt(3) will erroneously interpret these as invalid
options, unless the user sets the POSIXLY_CORRECT environment variable.
Specifying a '+' prefix ensures that these will be treated as regular
arguments.

With POSIX getopt, option arguments may or may not be in separate argv[] elements.
If the user bundles the option argument, such as -p/run/choparp.pid, the option
parsing code in main() would skip over the first non-option argument.

Fixed in patch 07-getopt-parsing as seen here:
perennialmind@1b9002d

The legacy BSD integer type aliases do not have sscanf codes; it appears as though an attempt to compensate may have yielded a type conversion error that would only affect 64-bit, big-endian architectures. Specifically, the cast to unsigned long in atoip() looks bogus. Unsigned long is a 64-bit quantity on I32LP64 archs, i.e. unix.

Fixed in 04-integer-conversion patch as seen here: perennialmind@a2019fe

User input handling in main() appears to assume at least one positive IP match. If all matches are negative, targets_filter will be null.

Fixed in patch 05-input-validation, as seen here:
perennialmind@f928723

Said patch contains miscellaneous changes for stricter input validation.