The settings should have an optional maxAttempts parameter, which allows to limit the number of retries in order to avoid long or endless loops.

Description:

Issue:

I have encountered an issue with the "mongoose-slugger-plugin" where slugs are not being generated as expected. The plugin is supposed to generate unique slugs for Mongoose documents, but in my testing, I've found that non-unique slugs are being generated under certain circumstances.

Steps to Reproduce:

• Create a Mongoose schema with the "mongoose-slugger-plugin" configured.
• Use the plugin to create documents, ensuring that there are potential conflicts in slug generation.
• Observe that in some cases, non-unique slugs are generated, violating the expected behavior.

Expected Behavior:

I expect the "mongoose-slugger-plugin" to consistently generate unique slugs for Mongoose documents, even when conflicts exist.

Actual Behavior:

Non-unique slugs are generated in some cases, leading to slug collisions.

Additional Information:

• I have configured the plugin according to the provided usage instructions.
• This issue occurs intermittently and is not consistently reproducible, making it challenging to pinpoint the exact cause.
• I'm using the latest version of the "mongoose-slugger-plugin"
• I have attached a code snippet of my schema and plugin configuration for reference.

import mongoose from "mongoose";
import { sluggerPlugin } from "mongoose-slugger-plugin";

const { Schema, model } = mongoose;

const schema = new Schema<any>(
  {
    userId: {
      type: mongoose.Schema.Types.ObjectId,
      required: true,
      ref: "User",
    },
    title: {
      type: String,
      required: true,
    },
    slug: {
      type: String,
      unique: true,
      require: true,
    },
    description: {
      type: String,
    },
    assets: {
      type: [{ type: String, required: true }],
      validate: {
        validator: function (items: []) {
          return items && items.length > 0;
        },
        message: "At least one asset is required",
      },
    },
  },
  { timestamps: true }
);

schema.index(
  { slug: 1, title: 1, description: 1 },
  { name: "search", unique: true }
);

schema.plugin(sluggerPlugin, {
  slugPath: "slug",
  generateFrom: ["title"],
  index: "search",
});

Environment:

• Node.js version: 19.8.1
• Mongoose version: 7.5.1
• Operating System: macOs

Please let me know if you need any additional information to investigate this issue.

Shippable currently shows something around 45 percent, but it should actually be 90 percent.

I am getting this error:

(node:5927) UnhandledPromiseRejectionWarning: MongoError: user is not allowed to do action [serverStatus] on [admin.]

Not sure why?

We're using atlas to host the mongodb

Can't install this now with latest mongoose at the package requires 5.0. Will it work with 6?

Like the title says, is this not supported?

const trip = await Trip.findOne({ _id: id, owner: userId }).exec()
trip.title = data.title
trip.description = data.description

await trip.save()

The slug remains the same.

Currently, the plugin exposes internal functions which should probably not be visible to the outside:

The following properties should be invisible (how can this be done?):

• createDefaultGenerator
• extractIndexNameFromError
• saveSlugWithRetries (maybe?!?)

It should be possible to configure a maximum length for the generated slugs. Ideas:

1. Implement this in the generator function (either a default, or entirely leave this to the client)
2. Add a maxLength parameter
3. Use mongoose's maxlength validator

Instead of

export declare function wrap<D extends Document>(model: Model<D>): Model<D>;

… it should probably rather be …:

export declare function wrap<D extends Document, M extends Model<D>>(model: M): M;

So that it plays will e.g. with @casl/mongoose.

The slugs I generate I don't want to necessarily be unique since they are accessed through another path /. However this plugin requires all slugs to be unique

Hello friends!
I am facing a problem when using with Typegoose, I am trying to allow users to create the same documents, but when using this plugin, I am getting error code 11000 when creating the document I am creating already existed before.
Here is my code, if I'm wrong please help me
Model.ts

Error message:

Thank all!

See how we can automatically publish to NPM (probably based on the vX.Y.Z tags?

See here:

nodkz/mongodb-memory-server#78

In this case, we cannot detect, where the duplicate exception happened. Can we add least add a check for the storage engine and show an error or warning to avoid any surprises here?

Should be possible through db.serverStatus().storageEngine (see here). See here for the Node.js API.

One could stupidly do something like this:

schema.plugin(slugger.plugin, new slugger.SluggerOptions({
  generator: (doc, attempt) => doc.whatever,
  // …
}));

The generated slug would not change (as the attempt is not considered) and produce an infinite loop (see also #2).

Add some checking logic, which verifies that the generated slug is actually unique before retrying.