qingwei-li / global-bin-path Goto Github PK

Using nvm-windows, nodejs 6.9.1, npm 3.10.8

The path returned is : undefined

The process.env.PATH is : C:\Program Files\nodejs

You want a PR or adding another test line 15 did the trick ? || path.basename(pathnames[i]) === 'nodejs'

On my computer, the directory nodejs is installed in contains the version: 'nodejs-6.9.1'.
In this case, global-bin-path returns 'undefined'.
Is it possible to change this line:
if (path.basename(pathnames[i]) === 'npm' || path.basename(pathnames[i]) === 'nodejs') {
to
if (path.basename(pathnames[i]) === 'npm' || path.basename(pathnames[i]).startsWith('nodejs')) {
?

As described in pnpm/pnpm#695, and quoting the README…

Return absolute path for global module executables, likes npm bin -g

but npm bin -g gives me /usr/local/bin (as expected), whereas this package resolves to /usr/local/Cellar/node/7.8.0.

macOS 10.12.4
node v7.8.0 (installed with homebrew)
pnpm v0.63.0