qaware / x-forwarded-filter Goto Github PK

Hi,

When an error causes the webapp to use the page defined in the error-page tag in web.xml, this filter doesn't try to handle the error dispatch.

I believe this is due to the code in OncePerRequestFilter.java:

    /**
     * Whether to filter error dispatches such as when the servlet container
     * processes and error mapped in {@code web.xml}. The default return value
     * is "true", which means the filter will not be invoked in case of an error
     * dispatch.
     *
     * @since 3.2
     */
    protected boolean shouldNotFilterErrorDispatch() {
        return true;
    }

Changing that to false fixes the issue for me.
Another option is to override shouldNotFilterErrorDispatch in ForwardedHeaderFilter.java if the desire is to preserve OncePerRequestFilter (which appears to come from Spring).

Hi @Michael-Frank

You made a great job, thank you. Unfortunately I can't use your filter and I need to use Tomcat's RemoteIpValve. What I especially need is to populate request.serverName from X-Forwarded-Host.
And I found a ticket with a patch in Bug 57665 - support x-forwarded-host
There in comment I described my situation and why I can't use your filter.
I checked that patch and code of whole RemoteIpValve and I think it can be significantly improved.
At least it would be great if it can support Forwarded header.

Unfortunately ATM I don't enough time to send to Tomcat a new patch but first of all I would like to ask you to contribute as a person who knows better how to implement this.

Can you help with this?
Thank you in advance