qaspen-python / psqlpy Goto Github PK

Hello, thank you for great job.

I added your driver to pgbeanch from MagicStack team. And result super different then your.
Full report https://public.jmarkin.ru/pgbeanch.html

Example result

psqlpy slower than all of other driver: aiopg, psycopg, asyncpg, etc.

Can you help me understand why your beanchmark give better results?

I'm trying to connect using ConnectonPool and getting an error
psqlpy.exceptions.RustPSQLDriverPyBaseError: Database engine pool exception: Error occurred while creating a new object: db error: ERROR: odyssey: c1fc39c4c6d6c: SSL is required

My connection string works for all of the other existing drivers

Do you have any workaround?

ATM to use connection we need to write the following code:

connection_pool = psqlpy.ConnectionPool()
conn = await connection_pool.connection()
conn.execute("SELECT * from users")

But it would be more pythonic to use context manager here like:

connection_pool = psqlpy.ConnectionPool()
async with connection_pool.connection() as conn:
    conn.execute("SELECT * from users")

Need to make chainable Connection Pool builder like in rust library.

Need to make PSQLPool.connection() method sync and add async context manager to it.
Main idea:
connection method will create new Connection(1) object with structure connection: None, db_pool: . And when user will call any method on connection(1), we need to acquire db pool for read, retrieve new connection(2), put it in our Connection(1) object and then use only connection(2) for querying.

Add async context manager like in Transaction.

Try to add close() method for connection(1) to use Drop trait.

By default, rust closes connection pool automatically when pool is dropped. But some people may want to close connection pool manually.
So, it's necessary to add close method.