Code Monkey home page Code Monkey logo

Comments (4)

dakra avatar dakra commented on July 16, 2024

We only use it to check for the current jedi version (

assert LooseVersion(jedi.__version__) >= LooseVersion(jedi_dep[1]), 'Jedi version should be >= %s, current version: %s' % (jedi_dep[1], jedi.__version__)
)

Mainly to check for Python3 compatibility.
I think instead of pulling in packaging in this bootstrap phase just for that is a bit much. Maybe we can roll our own very simple version.
Doesn't even have to work for all different kind of version string.. just like the
jedi ones e.g. 0.17.2 or 0.18.1. Maybe a simple ver[4:] > dep[4:] or something is even enough.
Do you want to try and find a solution and create a PR?

Thanks.

from anaconda-mode.

enikar avatar enikar commented on July 16, 2024

well, today I wrote a weak solution. It was a little more complex that what
you said. But I don't know how to create a PR… I juste create a patch, at the
moment.

from anaconda-mode.

enikar avatar enikar commented on July 16, 2024

Finally, I found how pull requests work.

from anaconda-mode.

dakra avatar dakra commented on July 16, 2024

Closed in #424

from anaconda-mode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.