Restricting newest jedi version allowed (and making it possible to configure this requirement) about anaconda-mode HOT 3 OPEN

Thanks for you comment.

I went with the distutils version as that's the most stable.
Your tuple function would e.g. break with "0.18a" etc.

I'm leaving this ticket open for now as I also think it would be
nice to at least automatically update the patch version or
make it configurable what jedi version should be installed.
(PRs welcome ;) )

from anaconda-mode.

Code-wise: the responsible lines are
https://github.com/pythonic-emacs/anaconda-mode/blob/master/anaconda-mode.el#L116
and
https://github.com/pythonic-emacs/anaconda-mode/blob/master/anaconda-mode.el#L157
and
https://github.com/pythonic-emacs/anaconda-mode/blob/master/anaconda-mode.el#L172

If it's to stay more-or-less this way, I'd suggest specyfying both sides, sth like

jedi_dep = ('jedi', '0.13.0', '0.18')   # min req. version, min illegal version
# …
missing_dependencies.append('{0}>={1},<{2}'.format(*jedi_dep))
# …
assert jedi.__version__ >= jedi_dep[1] and jedi.__version__ < jedi_dep[2], 'Jedi version should be >= %s and < %s, current version: %s' % (jedi_dep[1], jedi_dep[2], jedi.__version__,)

except the assert is invalid (text comparison doesn't work properly here, one must compare versions numerically, there are various libraries which can do it, I am not sure which one is appropriate here)

from anaconda-mode.

Patch above solves most important part of the issue, by forcing specific jedi version when one is to be installed. Still, there are two minor issues to consider:

a) Patched version switches to strict version (installs jedi==0.17.2 or jedi==0.18.0 depending on python version). Mayhaps it would make sense to allow for patchnumber upgrade (say, to install 0.17.3/0.18.1 if such version is released). Not 100% sure though.

b) Patch does not properly fix assert statement, leaving it as

assert jedi.__version__ >= jedi_dep[1], 'Jedi version should be >= %s, current version: %s' % (jedi_dep[1], jedi.__version__,)

(

def versiontuple(v):
    return tuple(int(x) for x in v.split("."))

from anaconda-mode.