python-poetry / crashtest Goto Github PK

A popular package manager poetry depends on crashtest.
However, because crashtest/frame.py doesnt' handle literal's encoding when it opens a file, UnicodeDecodeError is raised on Windows machine for non-English users.

File "C:\Users\chlje.poetry\lib\poetry_vendor\py3.8\crashtest\frame.py", line 51, in file_content
file_content = f.read()
UnicodeDecodeError: 'cp949' codec can't decode byte 0xe2 in position 1169: illegal multibyte sequence

A quick and easy fix is adding encoding='utf-8' option when opening the file.

This prevents a very large project poetry from failing to display text on many non-English users' machines with minimum modification.

I'll make a PR to solve this issue. Seems like the project has been stale for some time, but it would be nice if you merged this to the master so that the projects like poetry that depend on this repository can benefit.

The sdist at PyPI is missing tests. Please add them to sdist to make the downstream testing easily possible. Thank you.

Hi.
Would it be possible to write some documentation for how to use this module.
Either that, or some form of usage in the README?