Is our use of annotations ok? about pyshader HOT 6 CLOSED

If our way of using annotations is indeed "incompatible", then I'd rather do something to fix it. Especially if it requires changing the spelling, we better do it sooner than later.

If this issue was limited to this repo, I would not care so much, but it applies to all code that defines python shaders.

from pyshader.

This is also a problem in any library that uses pyshader.

from pyshader.

The weird thing is, if I change the spelling to what we (more or less) had earlier:

@python2shader
def vertex_shader(
    index: Input("VertexId", i32),
    out_pos: Output("Position", vec4),
    out_color: Output(0, vec3),
):
    ...

-> flake8 still produces the error for the arguments, which are str...

from pyshader.

We could use default-values instead of annotations. Though it would be sad, because we are using it exactly for its purpose, to annotate types. It's just shader types...

from pyshader.

The weird thing is, if I change the spelling to what we (more or less) had earlier:

@python2shader
def vertex_shader(
    index: Input("VertexId", i32),
    out_pos: Output("Position", vec4),
    out_color: Output(0, vec3),
):
    ...

-> flake8 still produces the error for the arguments, which are str...

That's either because str are considered "forward type declarations" or because flake8 does not evaluate the type declarations. I was bothered by this too and decided to ditch F821 in pylinalg. With good enough test coverage, it's not a big deal imho.

from pyshader.

Looking at the discussion here: PyCQA/pyflakes#529

Our use seems to be incompatible with the PEP indeed. Attaching arbitrary data is not yet supported. Apparently we should keep an eye out for PEP 593.

For now I suggest we just keep using it and ignore the flake8 error.

from pyshader.