pwolfert / hubot-wizards-duel Goto Github PK

Right now information for a given duel between two players is stored under a few keys, and there's no real performance benefit to doing that. We should just get the full duel state once we receive a command and pass that to all the functions and save one thing at the end.

It would also be nice to somehow refactor it to actually not mutate the state as we pass it to these functions. That being said, debugging is somewhat difficult in this app, so I should probably look into different ways to debug.

The Slack adapter for hubot is deprecated. BotKit seems to be a pretty stable and portable framework that I could move it to instead.

Refactor to make the Player, Spell, ..., modules a series of pure functions that return a new state. As spell interactions get more complex, it's harder to keep track of the state changes and make sure we don't introduce bugs caused by data mutation.

Right now there's too much in the way of testing it out. It should be easy enough to create an adapter for a little node cli app