pvhil / faceitdiscord Goto Github PK

Can be done without checks

Wouldn't it be easier to do it this way:

faceitLevelPNG = "https://raw.githubusercontent.com/pvhil/FaceItDiscord/master/src/main/resources/images/" + String.valueOf(faceitAPI.faceitLevel) + ".png";

P. S.
You also have a different case of the file extension in the folder where the pictures are located src/main/resources/images. In Windows, there is a conflict because of this, I did not make a pull request.

Lots of code for maps checks:

//over if checks
boolean containsMap = Arrays.asList(MAPS).contains(savedMap.toLowerCase(Locale.ROOT));

if (args[1].equalsIgnoreCase("last") || args[1].equalsIgnoreCase("latest") || containsMap) { 
//some code
}

P. S.
I can't cover the entire hierarchy/architecture of your code in a couple of minutes, but I think it will give you food for thought.
Probably my option is not very reliable, but in my case it works pretty well.