Code Monkey home page Code Monkey logo

bistro's People

Contributors

carinerey avatar cecilpert avatar pveber avatar sylverebastien avatar xclerc avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

bistro's Issues

build failure with Ocaml 4.13

File "ppx/bistro_script.ml", line 205, characters 58-59:
File "ppx/bistro_script.ml", line 205, characters 58-59:
205 |           (new ast_translation loc'.loc_start)#expression e
205 |           (new ast_translation loc'.loc_start)#expression e
                                                                ^
                                                                ^
Error: This expression has type Parsetree.expression
Error: This expression has type Parsetree.expression
       but an expression was expected of type
       but an expression was expected of type
         Ppxlib.Ast.expression = Astlib.Ast_412.Parsetree.expression
         Ppxlib.Ast.expression = Astlib.Ast_412.Parsetree.expression

docker mode does not work on mac os x

It seems mounts as they are done in engine/Task do not work on MacOS X, probably because Docker runs in a virtual machine, which doesn't host the files

Improve/simplify task description

  • docker commands should not be executed outside docker (suppress use_docker option in Bistro_app)
  • commands should specify a shell
  • new task that would just create a file with a given contents specified as an expression (for config files or scripts) --> done with e722f2e

build failure due to ppxlib 0.23 incompatibility

Upstreaming this from Nixpkgs:

# File "ppx/bistro_script.ml", line 201, characters 18-41:
# 201 |           let e = Parser.parse_expression Lexer.token (Lexing.from_string txt) in
#                         ^^^^^^^^^^^^^^^^^^^^^^^
# Alert deprecated: module Ppxlib.Parser
# Accessing this module directly is deprecated, use Ocaml_common.Parser instead
# File "ppx/bistro_script.ml", line 201, characters 18-41:
# 201 |           let e = Parser.parse_expression Lexer.token (Lexing.from_string txt) in
#                         ^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound value Parser.parse_expression

Indeed Nixpkgs simply patches Parser.parse_expression to Ocaml_common.Parser.parse_expression here.

ppx: add parameters

Bistro functions may have arguments that are not workflows. In that case, the workflow's id should depend also on the value of these arguments, which cannot be expressed at the moment. Let's call these arguments parameters.

Don't run docker commands as root

Currently all commands executed through docker are executed as root (in the container), which has (at least) two drawbacks:

  • it creates output files owned by root on the "host" file system
  • some tools (like meme in mpi mode) refuse to be run as root.

One solution would be to execute command through docker after changing user in the container, choosing the same uid than the (bistro) process owner.

engine: add a "network bandwidth" resource

When several tasks require significant bandwidth, it would be better to run them one after the other, to avoid too much idling. One solution would be to have a flag to say that a workflow consumes mostly network bandwidth and add network bandwidth as a limited resource.

Make a pipeline for phylogeny

Suggestion for a phylogenetic pipeline by @Boussau:

Items of the same level are alternatives

clustering:

  • blast then
    • orthomcl
    • silix (+hifix)

alignement:

  • mafft
  • clustal-omega
  • muscle
  • prank
  • Saté
  • Pasta

gene phylogeny:

  • PhyML
  • RaxML
  • IQTree
  • GARLI
  • mrBayes
  • Paup
  • Beast
  • fasttree
  • revBayes

species phylogeny:

  • MPEst
  • Astral

singularity binds

Singularity offers ro or rw mounts, with the syntax:

singularity shell --mount /host:/guest:ro ...

Would be nice to use for cache and inputs.

Please specify license

Looking at content of files, looks like software is GPL.

Would be nice to get in README, or in a LICENSE file, the license of the software to inform users without needing to dig in files
:-)

Generate relative links in a Bistro_app.plan

The repository generated by Bistro_app.with_backend is populated with absolute links to the cache, but this prevents a move of the containing directory. It would be better to switch to relative links.

add env variables in DSL

Would be convenient to have a mechanism general allowing to inject run-time values in workflow scripts. Scripts can then be slightly customized while not changing their ID. Variables like np and mem could be reimplemented this way, and that would be a nice way to introduce the name of the currently run executable (to implement custom procedures in a portable way).

Serialization of workflows is space-inefficient

For large workflows with many shared sub-workflows, the serialization via s-expressions produces a very large representation (exponential?). This hurts in particular when saving a workflow description in the database (currently only in the statistics table).

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.