Comments (19)
ccpandhare
commented on July 20, 2024
Yes, It should work!
from image-sequencer.
ccpandhare
commented on July 20, 2024
There's a small problem here:
https://runkit.com/embed/epjvm3wepv8c
TypeError: ImageSequencer is not a function
from image-sequencer.
ccpandhare
commented on July 20, 2024
Is this still waiting for npmjs to update?
from image-sequencer.
jywarren
commented on July 20, 2024
yeah i dunno why it's stuck... i reported the module missing again.
…On Wed, Jul 26, 2017 at 10:07 PM, Chinmay Pandhare ***@***.*** > wrote:
Is this still waiting for npmjs to update?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJxhp--TJYzDeIAxG7qfXFTC4GgG7ks5sR5x0gaJpZM4Ohf4L>
.
from image-sequencer.
ccpandhare
commented on July 20, 2024
I realized we have the same issue as in fisheyegl/#17
We are requiring in ./dist/image-sequencer.js which returns an empty object {}. That is why the RunKit isn't working.
While testing we usually do require('./src/ImageSequencer.js') and not require('./dist/ImageSequencer.js'). The latter returns an empty object, the former returns the intended Image Sequencer function.
from image-sequencer.
ccpandhare
commented on July 20, 2024
Is there a workaround for this such that browserify produces a file which can be both used in Browser as well as required in Node?
from image-sequencer.
jywarren
commented on July 20, 2024
hmm, i'm not sure... can you do a check for window, and instantiate
accordingly? Or perhaps we need to append a separately wrapped version for
node usage?
…On Wed, Jul 26, 2017 at 11:01 PM, Chinmay Pandhare ***@***.*** > wrote:
Is there a workaround for this such that browserify produces a file which
can be both used in Browser as well as required in Node?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ9t5WIh18rZ50Uy7vcaZjlEs99Iqks5sR6kpgaJpZM4Ohf4L>
.
from image-sequencer.
ccpandhare
commented on July 20, 2024
I already am instantiating according to the presence of window. That's why :
./src/ImageSequencer.jscan be required in Node.js./dist/image-sequencer.jscan be run in Browser
Maybe this has to do with the way Browserify handles everything, I am not sure...
from image-sequencer.
ccpandhare
commented on July 20, 2024
What would happen if we changed package.json to:
...
main: "src/ImageSequencer.js"
...?
Whoever is using npm will be require()-ing Image Sequencer, so it should work for everyone...
Is ./dist/image-sequencer.js supposed to be served by npm, or by a CDN?
from image-sequencer.
jywarren
commented on July 20, 2024
I was just thinking the same thing. Let's try it! You can npm require a
branch directly via a URL from an upstream package.json to test it out.
…On Jul 26, 2017 5:25 PM, "Chinmay Pandhare" ***@***.***> wrote:
What would happen if we changed package.json to:
...
main: "src/ImageSequencer.js"...
?
Whoever is using npm will be require()-ing Image Sequencer, so it should
work for everyone...
Is ./dist/image-sequencer.js supposed to be served by npm, or by a CDN?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ9Lh0ZS7nd6CrKT3X353mJcVYYtZks5sR67EgaJpZM4Ohf4L>
.
from image-sequencer.
ccpandhare
commented on July 20, 2024
Yes I have tried it! It works!
npm i git+https://github.com/ccpandhare/image-sequencer.git#npm
from image-sequencer.
jywarren
commented on July 20, 2024
Super. Merge a PR with that package.json and bump the version number, and
let's try runkit again. :-)
…On Jul 27, 2017 1:35 AM, "Chinmay Pandhare" ***@***.***> wrote:
Yes I have tried it! It works!
npm i git+https://github.com/ccpandhare/image-sequencer.git#npm
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0auWrUc2UohYvS48AI8Ce4ksEQxks5sSCGpgaJpZM4Ohf4L>
.
from image-sequencer.
ccpandhare
commented on July 20, 2024
I have merged the PR ( #84 ).
I don't have publish privileges, So I can't bump the version, so I request you to publish the new version!
It must work this time :-)
from image-sequencer.
jywarren
commented on July 20, 2024
OK, i published but then noticed #84 failed tests? Can you figure that out?
https://www.npmjs.com/package/image-sequencer
Thanks!
from image-sequencer.
ccpandhare
commented on July 20, 2024
I checked TravisCI. #84 had passed. The build didn't fail, I think the "cross" is shown on the commit in #84 because I merged it in before the TravisCI build completed.
from image-sequencer.
jywarren
commented on July 20, 2024
Ah ok!
…On Jul 27, 2017 2:56 PM, "Chinmay Pandhare" ***@***.***> wrote:
[image: screenshot_ -]
<https://user-images.githubusercontent.com/20787612/28687169-372cf34e-732b-11e7-8633-795daf05d80d.jpg>
I don't think #84 <#84>
failed tests, It's just that I merged the PR before the TravisCI build
completed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#74 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJyeNnqR0D1IDRUJ1IdOkE0tpKk5Fks5sSN1WgaJpZM4Ohf4L>
.
from image-sequencer.
ccpandhare
commented on July 20, 2024
https://runkit.com/embed/hvtvir55gm5v
It works now!
from image-sequencer.
ccpandhare
commented on July 20, 2024
Closing this issue.
from image-sequencer.
jywarren
commented on July 20, 2024
Great, can you add this to the README too?
from image-sequencer.
Related Issues (20)
- Adding an image sharpening module
- Removing scroll-to-top on mobile devices HOT 5
- Focus stacking module implementation HOT 1
- Halftone angle (in radians) needs to be a decimal instead of an integer HOT 3
- Dependencies Requiring Manual Upgrades HOT 1
- Remove Unused Dependencies HOT 1
- Supported NodeJS Versions HOT 3
- New module idea: ocr text recognition
- Use Modern JS HOT 2
- Can add units to the dimension of the image HOT 10
- How do I specify "executablePath" when calling Puppeteer HOT 5
- yarn.lock vs. package-lock.json HOT 1
- Checklist and coordination for v3.7.2 patch release and v3.7.3 follow-up patch release HOT 8
- Ideas for next release HOT 2
- Yarn complains about [email protected] expecting node 0.8.x HOT 13
- New module idea: descreen/dehalftone/inverse halftone
- Checklist and coordination for v3.8.0 minor release
- Incorrect local path for manipulation.wasm when using as an embedded library in MapKnitter.org
- eslint-error : Expected linebreaks to be 'LF' but found 'CLRF' HOT 1
- all thumbnails are not visible in the add step box HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image-sequencer.