Namespaced persistent data for each module about image-sequencer HOT 16 OPEN

That's nice!
What exactly should be stored that way?

from image-sequencer.

from image-sequencer.

Okay! Got it! Thanks :-)

from image-sequencer.

What can be done about the module repetitions in this regard? Then we will need different namespaces for each repetition. So, is this a viable option? :

var metadata = [
    { /* ndvi-red data */ },
    { /* segmented-colormap-data */ },
    { /* decode-qr data */ }
];

It doesn't sound like a good idea for further repetitions to replace the previous metadata of the same module.

from image-sequencer.

Or this:

var metadata = {
    ndvi-red: [ {}, {}, ... ],
    decode-qr: [ {}, {}, ... ]
};

This sounds better. Accessing metadata would be like (for the latest repetition): (pseudocode)

metadata['ndvi-red'][-1].key;

from image-sequencer.

You know, I think actually later modules should overwrite previous ones. Or should move previous ones to an older namespace or something. Say, if the QR code module generates metadata.decode-qr, you should get the most recent result in that value. Maybe each could return an object, but the object can have metadata._MODULENAME_.previous?

from image-sequencer.

Okay... What you say is definitely correct for a QR Decode module.
But say, for a Crop module, it won't be valid. The image might be cropped multiple times so I think we should preserve that data as well.

from image-sequencer.

from image-sequencer.

About multiple crops : We could track how the image transformed over time.

Okay I get what you are saying about the namespace, shall do.

from image-sequencer.

Will it work for the getMetadata function to be passed in to the module instead of the entire sequencer?

I feel that the module shouldn't have access to the sequencer because the module is a part of the sequencer and should not get access to other images, sequencer methods like loadImage, addSteps, etc.

from image-sequencer.

from image-sequencer.

Yes, that's true. Some more thought is required here.
I shall think about this and come up with a plan.

from image-sequencer.

from image-sequencer.

Is this still open then?

from image-sequencer.

Yes this still is open...

from image-sequencer.

This is addressed in #77

from image-sequencer.