Return value of run() and its documentation about image-sequencer HOT 11 CLOSED

I think it would be better to have a syntax like

sequencer.run(function(out){
    //do something with "out"
});

Where out is the output of final module.
There won't be any issue of order in this way.

Giving run a return value may not work, as run is more of an asynchronous function.
Also, it will render run unchainable thereafter (run is usually the last method, but still)

from image-sequencer.

from image-sequencer.

from image-sequencer.

run() already accepts a callback function. I think an onComplete type syntax could actually work wonders.

sequencer.run().onComplete(funnction(out){
    //do something with "out"
});

from image-sequencer.

from image-sequencer.

Thanks a lot for pointing that out!
I don't know how I missed that there.
Looks like I need to make quite a few changes to the Readme. Will open a PR for that tomorrow.

As for the return issue, I will look into the applications, benefits and shortcomings of each of the methods discussed here and will come up with a solution by tomorrow.

from image-sequencer.

from image-sequencer.

yes re: unchainable, but that's OK!

from image-sequencer.

No, I'd like to clear myself here.
This will work and allow chaining, and this is what we should do:

sequencer.run(function(out){
    // do something
});

This will neither work nor allow chaining:

function run() {
...
return this; // this refers to the sequencer here
}

So I will start working on the first one right away.

from image-sequencer.

oh huh, great!

from image-sequencer.

Fixed in #47

from image-sequencer.