Code Monkey home page Code Monkey logo

Comments (4)

rickecon avatar rickecon commented on June 11, 2024

@jdebacker makes a strong case for waiting to add this until the repository is a little more mature.

from og-uk.

jdebacker avatar jdebacker commented on June 11, 2024

@rickecon You can see in PR #2 that codecov reports are already being generated and shown in the conversation. I think this solution could could well, i.e., show coverage reports in PR conversations, but don't have a codecov check as in OG-USA that gives the red X on the PR checks. It's that red X that I wanted to avoid here as I don't like merging PRs with them, but it may be hard to start with and maintain 100% coverage of all new code as this repo hopefully adds a bunch of things quickly.

from og-uk.

rickecon avatar rickecon commented on June 11, 2024

@jdebacker I agree that we should add the codecov CI check later as the repo is more mature. However, we should really do it in a way that does not require 100% coverage. This is something that I am sure we can figure out. But I am happy to push this until later.

from og-uk.

jdebacker avatar jdebacker commented on June 11, 2024

Since code coverage is now reporting, I'm closing this issue.

from og-uk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.