Code Monkey home page Code Monkey logo

Comments (9)

jdebacker avatar jdebacker commented on June 11, 2024 1

@rickecon Thanks for this detailed report and for drilling down on the source of the errors.

I'm getting the same errors your report when I try to create the environment on my machine (running Mac OS 11.5.2). Note that in PR #22, the GH Actions were able to build the environment without problem on Linux and Windows.

from og-uk.

jdebacker avatar jdebacker commented on June 11, 2024 1

Per @nikhilwoodruff's suggestion, I set python<=3.7.11 and my environment built and I can create the oguk package and run the model.

from og-uk.

rickecon avatar rickecon commented on June 11, 2024

I commented out the - git+https://github.com/PSLmodels/openfisca-uk line in environment.py, cleared any old oguk-dev conda environment material, and created the new oguk-dev environment. Everything went well and smoothly, although it took 26 minutes (2 minutes for the initial environment dependencies and 24 minutes for the pip install of OG-Core). But it worked. So the conflict is definitely being generated by the pip install of openfisca-uk.

@jdebacker @nikhilwoodruff @MaxGhenis @jpycroft

from og-uk.

rickecon avatar rickecon commented on June 11, 2024
  1. We need to find out why this is not working on Mac OSX.
  2. We need to confirm that the environment can build on a Windows and/or Linux machine (e.g., like @jpycroft's or @nikhilwoodruff's)
  3. Should we add OSX to the matrix.os in the OG-UK GH Action?

@jdebacker

from og-uk.

nikhilwoodruff avatar nikhilwoodruff commented on June 11, 2024

@rickecon I should be able to test this later, but at first glance it looks like the (or at least one) issue is that the Python version is 3.9 - currently we're only building OpenFisca-UK on 3.7.7, so might need to add a <= condition in the version requirement?

from og-uk.

jdebacker avatar jdebacker commented on June 11, 2024

@rickecon asks:

Should we add OSX to the matrix.os in the OG-UK GH Action?

Unfortunately, adding OS X to the testing matrix isn't straight-forward (see this Tax-Calculator PR for discussion and links to more info).

from og-uk.

jdebacker avatar jdebacker commented on June 11, 2024

@rickecon Can you try again using the main branch now that I've merged PR #29?

from og-uk.

jpycroft avatar jpycroft commented on June 11, 2024

@jdebacker @rickecon @nikhilwoodruff

Hi Jason,

I’ve been trying out the new oguk-dev environment and (drum roll please … ) it installs! The conda activate oguk-dev worked fine. And no errors with the “pip install -e .” I've attached the conda output below.

Then I thought I’d try to run the example “python run_oguk.py” in the “examples/” folder. This generated over 5000 lines of errors. Many errors reference matplotlib (I checked that my matplotlib is up-to-date, of course). I've also attached that output below.

Best, Jon

Conda_output-oguk-dev_08sep2021.txt

Conda_output-run_oguk_08sep2021.txt

from og-uk.

jdebacker avatar jdebacker commented on June 11, 2024

@jpycroft Thank you for the report!

I'll close this issue (since you were able install the environment). And I'll take a look at the tracebacks from your trying to run the example. I'll also open up an issue to discuss that.

from og-uk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.