Updates Needed for Ema and Orange Displays about rileylink_ios HOT 10 CLOSED

Marion. I'm running the latest L&L build script workspace and get an error when trying to apply the the patch.

from rileylink_ios.

Screenshot?

• Are you getting a patch error or a build error?
• Are you using Xcode 13?
• Are you aware of this Xcode 13 build error and solution?
  • https://loopkit.github.io/loopdocs/build/build_errors/#xcode-13-indexing-not-finished-watchapp-extension-entitlements

I don't know why Xcode 13 is so difficult and throws this error so often.
But that would be a different issue - not to get off topic here.

I suggest you build successfully before applying the patch.
For me, I had to clear the WatchApp Extension.entitlements error, then build.
Follow the steps as listed above and shown in this graphic (I added a few extra git status that are not required but confirm HEAD detached at 15d1997).
Successfully built with the patch and the Ema and Orange displays were updated as expected.

Note - there are still some things about this patch that I think need adjusting. Happy to get feedback and suggestions.

from rileylink_ios.

Yes I have XCode 13 and successfully build and deplyed to phone and watch. I copied the patch to my rileylink_ios folder and attempted apply.

from rileylink_ios.

You had already made changes to those 2 files. You can only apply a patch to a fresh copy of rileylink_ios HEAD detached at 15d1997. (Or at least those two files cannot be modified from fresh copy.)

Try these commands to fix what you currently have.
This moves the patch out of directory up one level, otherwise stash will remove it.

mv ema_ol_fix_master_15d1997.txt ..

Restore clean copy of rileylink_ios

git stash

Now apply the patch

git apply ../ema_ol_fix_master_15d1997.txt

from rileylink_ios.

Deerp. Thanks for my obvious dopey ness.. I've applied the patch and have deployed it to my device. Testing now.

from rileylink_ios.

Working great on my OL Pro. Will do some further testing this week no problems thus far.

from rileylink_ios.

Hi @marionbarker, I got a bunch of build errors when applying the patch to loop V2.2.6. I have an OL Pro FW3.2/HW1.1.
Any idea what I may have done wrong?

from rileylink_ios.

Are all of these changes in dev at this point? If not, please identify what is remaining. If a patch can be created, I can review it, or I can look into getting the remaining issues resolved.

from rileylink_ios.

None of these changes are in dev yet.
Using this commit: 6321592:

• OrangeLink Pro does not display Find Device
• EmaLink does not display battery, battery level alert or Invert LED Logic row

I did

git apply ema_ol_fix_master_15d1997_vs2.txt

and displays of both are as desired.

from rileylink_ios.

@ps2 I just looked at this again today based off a facebook comment. I think there was some confusion when you closed this issue. It's fixed in dev but not in master. I've updated the patch instructions to include the updated commit number for rileylink_ios.

We point to the patch instructions in LoopDocs. Scroll down to the admonition that says Patch Required for Loop 2.2.x

from rileylink_ios.