Add v2.2.5 improvements for RL to dev branch about rileylink_ios HOT 5 CLOSED

I looked at the modifications that were implemented to fix the "ema" problem and to clean up some "orange" comms leading up to loop-release/v2.2.5 (commit 15d1997 of rileylink_ios).

I believe the attached patch captures the modifications needed for dev branch to have these same improvements.

I have been using this patch successfully on dev branch on myself using EmaLink and OrangeLink Pro for more than one week. The naming of the patch might need some explanation. The "master" referred to in the name is the LoopWorkspace build for master that points to rileylink_ios commit 15d1997.

I started with LoopWorkspace build of dev branch, which points to commit 44eab01 of rileylink_ios. The following commands assume the patch is downloaded to your Downloads folder:

cd rileylink_ios
git apply ~/Downloads/dev_RL_BLE_UI_44eab01_to_master_15d1997.txt
cd ..
xed .

This patch modifies the following files, and includes the Xcode 13 plus Xcode 12 code changes:

• RileyLinkBLEKit/PeripheralManager+RileyLink.swift
• RileyLinkBLEKit/PeripheralManager.swift
• RileyLinkBLEKit/PeripheralManagerError.swift
• RileyLinkBLEKit/Response.swift
• RileyLinkBLEKit/RileyLinkDevice.swift
• RileyLinkKitUI/RileyLinkDeviceTableViewController.swift

dev_RL_BLE_UI_44eab01_to_master_15d1997.txt

from rileylink_ios.

I realized the name is not actually very good. (That symptom is what I noticed first.) So changed the name.

Also renamed the stream in zulipchat:

• https://loop.zulipchat.com/#narrow/stream/144182-development/topic/dev.3A.20v2.2E2.2E5.20RL.20upgrades.20not.20in.20dev/near/253490901

from rileylink_ios.

@marionbarker Here are the logs and export data reports from an Pod Pairing issue that I experienced with your patch dev_RL_BLE_UI_44eab01_to_master_15d1997.txt patch. Unfortunately the data was collected after I Paired another Pod successfully right afterward so I do not know how helpful this is. As I mentioned on Zulip, I've only seen two Pod Pairing issues with your patch in the 7 weeks I've been testing your patch.. Do you have any plans to submit a PR request for this patch to the dev branch?

Export-20211225T224651Z.zip
Loop Report 2021-12-25 17_46_14-05_00.md

from rileylink_ios.

@marionbarker Good news. I had another Pod failure on pairing today and was able to capture the Issue Report and the Critical Events Export. I was also able to capture a couple of screen captures. All of these are attached below. The short of it, the error was 092 prime count too low.

092 | 0x5C | Prime open count too low | Problem with a safety check after priming

Export-20220122T165526Z.zip
Loop Report 2022-01-22 11_52_53-05_00.md

from rileylink_ios.

dev branch updated a while ago. Closing this.

from rileylink_ios.