Code Monkey home page Code Monkey logo

pronamic-pay-worldline-open-banking-ideal-2's Introduction

pronamic-pay-worldline-open-banking-ideal-2's People

Contributors

remcotolsma avatar rvdsteege avatar

Stargazers

avatar

Watchers

avatar avatar avatar avatar

pronamic-pay-worldline-open-banking-ideal-2's Issues

Rename "Merchant ID" to "Initiating Party ID"?

Should we rename "Merchant ID" to "Initiating Party ID"?

pronamic-pay-worldline-open-banking-ideal-2/src/Integration.php

Lines 102 to 121 in 2acb3e5

// Merchant ID.
$merchant_field = [
'section' => 'general',
'title' => __( 'Merchant ID', 'pronamic-pay-worldline-open-banking-ideal-2' ),
'meta_key' => '_pronamic_gateway_ideal_merchant_id',
'type' => 'text',
'classes' => [ 'code' ],
'tooltip' => sprintf(
'%s %s.',
__( 'Merchant ID (or Acceptant ID)', 'pronamic-pay-worldline-open-banking-ideal-2' ),
__( 'as mentioned in the payment provider dashboard', 'pronamic-pay-worldline-open-banking-ideal-2' )
),
];
if ( null !== $this->merchant_options ) {
$merchant_field['type'] = 'select';
$merchant_field['options'] = $this->merchant_options;
}
$fields[] = $merchant_field;

Header Value Description
App IDEAL App value is always IDEAL for iDEAL transactions.
Client RaboiDEAL Client value is always RaboiDEAL for Merchants with Rabobank
Id Initiating Party ID* This is the identifier used by the Open Banking Service to identify the Merchant.
In the test environment, only the test Merchants should be used.

* The Initiating Party ID for a Merchant can be found in the Rabo iDEAL Dashboard via the Merchant Page or
the Subscription Page. This is also known as "Dashboard ID" for Rabobank Merchants. Please note this is to
be taken from the Rabo iDEAL Dashboard l for transactions in Production.

Source: iDEAL_2.0_Getting_Started_Guide_-_version_1.4 - Rabobank.pdf

CC @rvdsteege

Fatal error `Uncaught Error: Call to undefined function submit_button()`

The configuration settings fields do not change when switching payment provider. This is caused by the following error:

Fatal error: Uncaught Error: Call to undefined function submit_button() in /wp-content/plugins/pronamic-pay-worldline-open-banking-ideal-2/src/Integration.php on line 432

pronamic-pay-worldline-open-banking-ideal-2/src/Integration.php

Lines 382 to 453 in fd7082f

/**
* Field private key.
*
* @param array<string, mixed> $field Field.
* @return void
*/
public function field_private_key( $field ) {
$post_id = (int) \get_the_ID();
$private_key = $this->get_meta( $post_id, 'ideal_private_key' );
$private_key_password = $this->get_meta( $post_id, 'ideal_private_key_password' );
$number_days_valid = $this->get_meta( $post_id, 'number_days_valid' );
if ( PronamicGateway::MODE_TEST === $this->get_mode() ) {
$private_key = \file_get_contents( __DIR__ . '/../certificates/TestCertificatesiDEAL.2.0.key' );
}
if ( PronamicGateway::MODE_TEST !== $this->get_mode() ) {
if ( ! empty( $private_key_password ) && ! empty( $number_days_valid ) ) {
if ( \function_exists( '\escapeshellarg' ) ) {
$filename = __( 'ideal.key', 'pronamic-pay-worldline-open-banking-ideal-2' );
$command = sprintf(
'openssl genrsa -aes128 -out %s -passout pass:%s 2048',
\escapeshellarg( $filename ),
\escapeshellarg( $private_key_password )
);
?>
<p><?php esc_html_e( 'OpenSSL command', 'pronamic-pay-worldline-open-banking-ideal-2' ); ?></p>
<input id="pronamic_ideal_openssl_command_key" name="pronamic_ideal_openssl_command_key" value="<?php echo esc_attr( $command ); ?>" type="text" class="large-text code" readonly="readonly"/>
<?php
}
} else {
printf(
'<p class="pronamic-pay-description description">%s</p>',
esc_html__( 'Leave empty and save the configuration to generate the secret key or view the OpenSSL command.', 'pronamic-pay-worldline-open-banking-ideal-2' )
);
}
}
?>
<p>
<?php
if ( ! empty( $private_key ) ) {
\wp_nonce_field( 'pronamic_pay_download_secret_key', 'pronamic_pay_download_secret_key_nonce' );
\submit_button(
__( 'Download', 'pronamic-pay-worldline-open-banking-ideal-2' ),
'secondary',
'download_secret_key',
false
);
echo ' ';
}
if ( PronamicGateway::MODE_TEST !== $this->get_mode() ) {
printf(
'<label class="pronamic-pay-form-control-file-button button">%s <input type="file" name="%s" /></label>',
esc_html__( 'Upload', 'pronamic-pay-worldline-open-banking-ideal-2' ),
'_pronamic_gateway_ideal_private_key_file'
);
}
?>
</p>
<?php
}

CC @remcotolsma

Store iDEAL transaction ID in payment

We're using a PaymentID from the response on payment initiation as the transaction ID of the payment:

pronamic-pay-worldline-open-banking-ideal-2/src/Gateway.php

Lines 83 to 85 in cd3c331

$payment_initiation_response = $client->create_payment( $payment_initiation_request );
$payment->set_transaction_id( $payment_initiation_response->common_payment_data->payment_id );

This ID (e.g. 190XXX) refers to the payment in the Open Banking Service and needs to be used in subsequent API calls, but is not mentioned in bank statements.

At support, a customer wants to use the bank statement transaction ID (e.g. 7020067062XXXXXX) for matching in Salesforce. Therefore it would be beneficial to also have this ID available within the Pronamic payment. I'm guessing that this ID can be obtained through AspspPaymentId in the 201 Created response on payment initiation:

  • PaymentId (required): Id generated by the Open Banking Service. This should be used to refer to this payment in subsequent api calls.
  • AspspPaymentId: Id used by the ASPSP/iDEAL Hub to refer to the payment.

Source: https://financial-services.developer.worldline.com/node/274#operation/paymentInitiate

Maybe we can store the ID in payment meta, @remcotolsma? Thoughts?

Internal Help Scout ticket: https://secure.helpscout.net/conversation/2506036239/26882

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.