promet / drupal7-framework Goto Github PK

After doing a fresh install the WYSIWYG module can't detect the version of the CKEditor library due to an issue in Drupal.org. This causes the Promet Default text format features to not be successfully reverted.

My initial solution is to

• Create a patch using the netresearch/composer-patches-plugin and adding it into the repositories array.

{
    "type": "package",
    "package": {
        "name": "promet/drupal7-framework-patches",
        "version": "1.0.0",
        "type": "patches",
        "require": {
            "netresearch/composer-patches-plugin": "~1.0",
            "drupal/wysiwyg": "7.2.2"
        },
        "extra": {
            "patches": {
                "drupal/wysiwyg": {
                  "7.2.2": [
                        {
                            "title": "Ckeditor 4.0 - The version of CKEditor could not be detected.",
                            "url": "https://www.drupal.org/files/wysiwyg-ckeditor4-1853550-4.patch"
                        }
                    ]
                }
            }
        }
    }
}

• Include the "patch package" into the require array "promet/drupal7-framework-patches": "~1.0.0",
• Remove the "drupal/wysiwyg": "7.*", from the require array since we have declared it inside the "patch package".
• Then do composer update

Any thoughts on this issue and solution or should we focus on Replace the wysiwyg module by the ckeditor module ?

We should be using the ckeditor module by default instead of the wysiwyg module.
ckeditor will be in core for Drupal-8 based on the ckeditor module, already availble for Drupal 7.
See "Drupal 7 - Future-proof your Drupal 7 site" https://www.drupal.org/node/2287495

https://www.drupal.org/node/2495517

That would allow use to use one of these:
https://packagist.org/search/?q=simplehtmldom

The devel_themer module now has a dependency on the simplehtmldom module, which includes the simplehtmldom library in its codebase. We need to remove the simplehtmldom library from the base composer.json file

A good practice for extension files that should never, ever, being added to git (.DS_Store, .vagrant, sass-cache ...) should be ignored using global gitignore file on your computer, not specially on the gitignore file of the project.
On how to do it, see "Create a global .gitignore" https://help.github.com/articles/ignoring-files/

I suggest removing the following lines from the gitignore file :
.vagrant/
.DS_Store
.bundle
.ruby-version
.sass-cache

https://www.drupal.org/project/master. Allows you to set the "Master" modules in settings. Seems to perform the same function as Dropship does primarily, which is to make sure only the items you need are enabled.