projek-xyz / slim-plates Goto Github PK

View Code? Open in Web Editor NEW

27.0 7.0 2.0 162 KB

Render your Slim 3 application views using Plates template engine.

Home Page: http://www.projek.xyz/slim-plates

License: MIT License

PHP 99.65% Smarty 0.35%

plates-templates slim-framework

slim-plates's People

Contributors

Stargazers

Watchers

Forkers

thomas89 exinfinite

slim-plates's Issues

Doc upgrade needed: first param $response on render method

Hello!! I'm using your slim-plates integration, it's great, but I cannot run your example because render method's first param doesn't psr7 response.

I try remove render methods' s first param and OK:

// Define named route
$app->get('/hello/{name}', function ($request, $response, $args) {
return $this->view->render('profile', [
'name' => $args['name']
]);
})->setName('profile');

Change your doc please.

Thanks for your integration!

Need a method to set response obj

Need a method with \Psr\Http\Message\ResponseInterface as param. So we don't need to pass it from render() method.

Slim 4

Have plans to migrate to slim 4?

Eventloop applications always use the same response

Need a way to set the response for each request made to the application, in apps like Swoole the response is set only the first time and not for each request. A middleware would be nice for updating the response object inside the library each request.

Need more Extension helper methods

Here the plan.

getCharset()

Retrieve charset value from Response::getHeaderLine('Content-Type').

Example Usage:
```
<head>
<meta charset="<?=$this->getCharset()?>">
```
getLang()

Retrieve default application language. Should be provided by $container['settings'] or Negotiation\LanguageNegotiator::getBest() from @willdurand/Negotiation.

Example Usage:
```
<html lang="<?=$this->getLang()?>">
```

more?

Code review

I just read the code a bit an this caught my eye:

https://github.com/feryardiant/slim-plates-view/blob/master/src/Plates.php#L119

Wont that return the return value of write? (which is an int)

Also, where is this $container coming from?
https://github.com/feryardiant/slim-plates-view/blob/master/src/Plates.php#L37
The container should be not be there at all. If you want to register the service in the container use the PlatesProvider

Add method to call Plates render without $response

Can you add the ability to call Plates render without $this->response->write()?

For example creating email templates and using Plates for template inheritance. And attach the rendered html to an email body instead of returning a view for a web response.

Something like this maybe? This would save from instantiating Plates again with the needed settings since we are already.

public function renderWithNoResonse($name, array $data = [])
{
  return $this->plates->render($name, $data);
}

projek-xyz / slim-plates Goto Github PK

slim-plates's People

Contributors

Stargazers

Watchers

Forkers

slim-plates's Issues

Doc upgrade needed: first param $response on render method

Need a method to set response obj

Slim 4

Eventloop applications always use the same response

Need more Extension helper methods

Code review

Add method to call Plates render without $response

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent