Code Monkey home page Code Monkey logo

Comments (10)

bkeepers avatar bkeepers commented on June 30, 2024

Interesting. I think that's a great idea.

Related: https://github.com/clarkbw/probot-in-progress @clarkbw

GitHub
probot-in-progress - A Probot that marks issues with a specific label when an in progress PR indicates they will be fixed

from stale.

stale avatar stale commented on June 30, 2024

Is this still relevant? If so, please comment with any updates or addition details.

from stale.

mlinksva avatar mlinksva commented on June 30, 2024

Thank you stale bot I guess you are serving your purpose, made me visit.

I see looking at the query built by stalebot and https://help.github.com/articles/searching-issues-and-pull-requests/ why https://github.com/clarkbw/probot-in-progress is so relevant -- there isn't a query operator for references, so to get at them, we'd need code similar to probot-in-progress that looks for references in other issues/pulls.

~3 ways to implement in stalebot, if I understand:

  1. Add (or not if desired as default) something like an exemptReferenced configuration parameter, if that's turned on or default either
    1. use probot-in-progress like code added to stalebot to unstale issues when referenced; seems not ideal because a referenced issue maybe should not be marked stale in the first place
    2. or do some post-filtering of query to eliminate issues that have been referenced (I don't know offhand how to do this but imagine it can't be that hard)
  2. Just document that one can set exemptLabels to include the ones populated by probot-in-progress and also install probot-in-progress if one does not want stalebot to mark issues that there's some evidence someone is working on as stale.

I suppose which is "right" depends in part on whether probots are typically kitchen sink or expected to do as little as possible and rely on other probots also doing very little to achieve something.

You can search for issues and pull requests using these search qualifiers in any combination. …
GitHub
probot-in-progress - A Probot that marks issues with a specific label when an in progress PR indicates they will be fixed

from stale.

stale avatar stale commented on June 30, 2024

Is this still relevant? If so, please comment with any updates or addition details.

from stale.

bsoyka avatar bsoyka commented on June 30, 2024

Will this feature be implemented after all?

from stale.

mlinksva avatar mlinksva commented on June 30, 2024

The documentation-only-work-with-probot-in-progress implementation above would be easiest. Is probot-in-progress going to be available from https://probot.github.io/apps/ at some point @clarkbw?

Probot
GitHub Apps to automate and improve your workflow

from stale.

clarkbw avatar clarkbw commented on June 30, 2024

some point @clarkbw?

I don't think I have the time. 😢

from stale.

bkeepers avatar bkeepers commented on June 30, 2024

…or do some post-filtering of query to eliminate issues that have been referenced (I don't know offhand how to do this but imagine it can't be that hard)

Right now stale relies heavily on GitHub search. If the notion of referenced could be added to search, it'd be really easy. I suspect though what you really want to know is if there is an open pull request that references this issue. That gets a little more complicated.

It'll likely mean an n+1 query for every open issue to see if there's a PR that references it.

I'm not opposed to adding this feature, but it'll likely require a bit of work. I'm happy to give feedback if anyone wants to attempt it.

from stale.

clarkbw avatar clarkbw commented on June 30, 2024

FYI, I had hoped to tackle the fundamental API issue this year. But don’t let my optimism there deter you from getting anything done.

from stale.

stale avatar stale commented on June 30, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

from stale.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.