Please add an option to suppress warnings which occure because of default ignored files like e.g. in the node_modules directory.

Thanks for the great extension!

At the moment, the only two warning types I can think of are files that have been ignored being passed through ESLint, and then real warnings for syntax issues. Need to figure out a way to suppress one or both in a less naïve way than #10.

I'm thinking the eventual implementation will be an extension of --quiet, like:

browserify your_file.js -t [ eslintify --quiet=ignored ]

This might not be a bug or is intentional, but i just wanted to confirm since i can't this config as a browserify transform, yet configuriged as a grunt task it will work fine.

{ "rules": { "indent": [ 2, 4 ], "quotes": [ 2, "single" ], "linebreak-style": [ 2, "unix" ], "semi": [ 2, "always" ], "no-console": 0, "no-undef": 0, "no-unused-vars": 0 }, "env": { "amd": true }, "extends": "eslint:recommended", "ecmaFeatures": { "jsx": true, "experimentalObjectRestSpread": true }, "plugins": [ "react" ] }

So this .eslintrc config will always throw an error (error Parsing error: Unexpected token <) when performed on jsx code for instance like this:

browserify app/app.js -t eslintify

So it is obviously not respecting jsx syntax.

but if i run it through grunt-eslint for example, it will compile fine.

Maybe i am doing something wrong here. Can't figure it out though.

Thanks in advance,
Simon

It's worth noting it works fine with Browserify (non watchify).

Trying to pass options to the plugin with v3.1.0 requiring the plugins as so.

var eslintify = require('eslintify');
var babelify = require('babelify');

Transforming the stream like so

        b.transform(eslintify, {formatter: 'json'}); 
        b.transform(eslintify, {passthrough: ['warnings']});
        b.transform(babelify, {presets: ['es2015', 'react'], plugins: ["transform-object-rest-spread"]});

results in no formatter change, nor any options being passed to eslintify.

I added a console.log into the mix to see what is being passed as the "options" parameter and did the same with babelify as a litmus.

eslintify

{ '0': '/js/core.components.js',
  '1': 
   { _flags: 
      { cache: {},
        packageCache: [Object],
        entries: [Object],
        external: [Object],
        insertGlobals: true,
        insertGlobalVars: [Object],
        poll: true,
        dedupe: true } } }

(object at index 1 are passed from watchify/browserify args)

babelify

{ '0': '/js/core.components.js',
  '1': 
   { presets: [ 'es2015', 'react' ],
     plugins: [ 'transform-object-rest-spread' ],
     sourceMaps: 'inline' } }

This is a simple and important feature I'm sorely missing. eslintrc is not enough when building different bundles tat have different requirements with browserify. Instead of duplicating options like quiet, IMO it would be way better to be able to use the documented ESLint options with eslintify. You may have to filter out the eslintify-specific options like continuous but that's easy to do.

In addition, I think it would make a lot of sense to set the --env "commonjs" option.

Could an option be exposed to skip the /\.(js|jsx|es6)$/ test, or configure the regular expression? I am using javascript transformed/extracted from HTML, so this skips many of the files I want to lint. The behaviour is a little surprising also, IMO.

In case this helps anyone reading, my current workaround is to fool it:

        .transform({ continuous: true }, function (file, options) {
            return eslintify(file + '.js', options);
        })

Thanks for a very useful plugin, Evan et al.

Here's the output of using eslintify with only warnings:

✘ 19 problems (0 errors, 19 warnings)                                                                                                                                                        


Warnings:                                                                                                                                                                                    
  19  http://eslint.org/docs/rules/global-require                                                                                                                                            
eslintify: linting error(s) detected.

Browserify exits after this with a 1 for the exit code.