Comments (6)
smcgregor
commented on July 20, 2024
Can you post screen captures so I can make sure we are looking at the same things? It looks like it is working as expected for me.
from privly-chrome.
kabochya
commented on July 20, 2024
from privly-chrome.
smcgregor
commented on July 20, 2024
Thanks for the screen captures. Do you have Javascript turned off? I think what is happening here is the options link is not being overridden by the popup.js script, which ensures the link opens in a new window.
from privly-chrome.
smcgregor
commented on July 20, 2024
I just tested on linux as well and it is opening two windows. I'll push a fix in a moment.
from privly-chrome.
smcgregor
commented on July 20, 2024
Actually, do you want to fix this? What you need to do is modify the .click functions in popup.js so that it prevents the link from opening a window after the .click event listener returns.
from privly-chrome.
kabochya
commented on July 20, 2024
Ok I will push it , thx!
from privly-chrome.
Related Issues (20)
- Privly icon scrolls with window HOT 1
- Privly Button doesn't work with TinyMCE HOT 17
- no file as chromeOptions.html HOT 4
- Privly posting doesn't work with Youtube comment HOT 10
- Only Automatically Close Posting Window if Pasting Successful HOT 3
- Iframes don't get resized
- Privly should not try to process URLs inside editable iframe HOT 2
- Change run_at property of privly.js? HOT 3
- Merge gsoc-develop to develop HOT 6
- Right click menu does not launch new message in google chat
- Implement proper rate limiting for iframe injection
- Erratic behavior on Facebook chat box HOT 4
- Broken Build HOT 1
- Fix CodeClimate Issues HOT 1
- Add Continuous Integration System to Forks
- Draw Attention to Extension Popup Icon on Installation HOT 6
- Remove LocalStorage on Uninstall HOT 5
- Use the chrome.runtime api onInstalled event to launch the firstrun page HOT 4
- Privly button weird behaiour HOT 1
- Add Integration Test for Injection Parameters
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from privly-chrome.