Comments (17)
I'm not sure I follow. Please provide steps to reproduce the error.
from privly-chrome.
@irdan http://www.tinymce.com/ Privly button doesn't show
from privly-chrome.
@summerwish Thanks for the context.
In the future try make the issues you create meaningful to anyone who reads just the issue in isolation. For example, the title of an issue should clearly describe what doesn't work and the description should provide enough context to reproduce the problem.
from privly-chrome.
@irdan Sorry for the inconvenience. I have changed title to a more precise one.
from privly-chrome.
@summerwish No worries. I know how easy it is to forget details like that when you're in the zone.
from privly-chrome.
WYSIWYGs are the worst. I suppose it is good to have an issue open for it, but I am not prepared to work out the issues with how a WYSIWYG would hold the link in its state.
This would be an interesting (although not central) test case for a Seamless Posting project, but for now, I think this is a "won't fix" because it is not worth the time investment.
from privly-chrome.
Found a interesting property of manifest.json
: match_about_blank
, which solves this issue LOL, at least in TinyMCE. To avoid conflicts when merging my PR #101 , I commited it in my PR instead of opening a new PR.
from privly-chrome.
Oh, wow. TinyMCE uses srcdoc iframes.
I wonder why they lumped about:blank
with about:srcdoc
. Any errors in the browser or the page's console when you open a new tab?
from privly-chrome.
no errors. In fact the URL of new tab is chrome-search://local-ntp/local-ntp.html
:-)
from privly-chrome.
huh. I get "https://www.google.com/_/chrome/newtab?espv=2&ie=UTF-8". Regardless, my concern was unwarranted.
from privly-chrome.
The code should work for real blank about:blank
.
BTW your NTP URL is interesting :-) On my Chrome it shows the new tab page but immediately jumps to Google
from privly-chrome.
This patch fixes CKEditor compatibility as well. As long as it is compatible with TinyMCE and CKEditor, it should cover most of WYSIWYG use cases for normal websites.
A still-not-working example: http://ueditor.baidu.com/website/onlinedemo.html (I'm still figuring out the real issue here)
Those emulated-editing cases are still not supported: http://www.alohaeditor.org/demo/aloha-ui/
from privly-chrome.
@summerwish Is this still not working? It is difficult for me to know what is happening on the example.
from privly-chrome.
@smcgregor Latest seamless-posting works in ueditor now. It is due to incorrectly handle designMode
property and DOM hierarchy in former versions of Privly button. Emulated-editing is still not supported.
from privly-chrome.
The "latest" version of seamless-posting is the one on gsoc-develop?
from privly-chrome.
Yes :-) This issue has already been solved.
from privly-chrome.
OK I think its time to close this issue :-)
from privly-chrome.
Related Issues (20)
- Privly icon scrolls with window HOT 1
- no file as chromeOptions.html HOT 4
- Privly posting doesn't work with Youtube comment HOT 10
- Only Automatically Close Posting Window if Pasting Successful HOT 3
- Iframes don't get resized
- Privly should not try to process URLs inside editable iframe HOT 2
- Change run_at property of privly.js? HOT 3
- Merge gsoc-develop to develop HOT 6
- Right click menu does not launch new message in google chat
- Implement proper rate limiting for iframe injection
- Erratic behavior on Facebook chat box HOT 4
- Broken Build HOT 1
- Fix CodeClimate Issues HOT 1
- Add Continuous Integration System to Forks
- Draw Attention to Extension Popup Icon on Installation HOT 6
- Remove LocalStorage on Uninstall HOT 5
- Use the chrome.runtime api onInstalled event to launch the firstrun page HOT 4
- Privly button weird behaiour HOT 1
- Add Integration Test for Injection Parameters
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from privly-chrome.