privex / django-mail-queue Goto Github PK

How should I integrate an external API to send the emails with the send_queued_messages command, while keeping this awesome interface?

It would be nice if send_queued_messages/send_queued could also be triggered via a celery task.

Django Version: 2.2.17
Django Mail Queue Version: 3.2.4

When trying to create a message from the Django admin, it does not allow one to enter My Name <[email protected]> in the from field. The validation tries to validate an email address.

Will you add support for Django 3?

django.utils.translation.ugettext_lazy() was deprecated in Django 3.0 and removed in Django 4.0.
Should be replaced by django.utils.translation.gettext_lazy()

When sending queued emails in bulk it is better to use a single connection with the SMTP server. Like suggested in django docs.

When you're using MAILQUEUE_CELERY = True and after a message is saved to DB by msg.save() you need to call .send_mail() method to the message is put to Celery queue and sent.

I didn't found this info on https://django-mail-queue.readthedocs.io so would be nice if can be updated.

Hello, it appears that mailqueue has a pending migration that has not been generated or added to source control. Would you be willing to add it?

Whenever I add django-mail-queue on a new project and run manage.py, I get the following message warning about it:

$ python manage.py migrate
Operations to perform:
Apply all migrations: ... mailqueue, ...
Running migrations:
No migrations to apply.
Your models have changes that are not yet reflected in a migration, and so won't be applied.
Run 'manage.py makemigrations' to make new migrations, and then re-run 'manage.py migrate' to apply them.`

I can manually generate this and apply it, and then the warning goes away:

$ python manage.py makemigrations
Migrations for 'mailqueue':
.../site-packages/mailqueue/migrations/0007_auto_20200316_1129.py
- Alter field file_attachment on attachment
- Alter field sent on mailermessage

$ python manage.py migrate
Operations to perform:
Apply all migrations: ... mailqueue, ...
Running migrations:
Applying mailqueue.0007_auto_20200316_1129... OK

However, it would be great if this could be generated and added to the existing django-mail-queue package. Thanks!

System check identified some issues:

WARNINGS:
mailqueue.Attachment: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
	HINT: Configure the DEFAULT_AUTO_FIELD setting or the MailQueueConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.
mailqueue.MailerMessage: (models.W042) Auto-created primary key used when not defining a primary key type, by default 'django.db.models.AutoField'.
	HINT: Configure the DEFAULT_AUTO_FIELD setting or the MailQueueConfig.default_auto_field attribute to point to a subclass of AutoField, e.g. 'django.db.models.BigAutoField'.

I'm getting this warning when running Django 3.2.12 with django-mail-queue 3.2.4. I believe its coming from this package. Is this something you'd accept a Pull Request for?

As of now it is not possible to pass custom headers to MailerMessage object, since this is supported by django's EmailMessage class it should also be supported here.