Some colors are hard to differentiate about github-vscode-theme HOT 2 CLOSED

This came up a few times.. #19 + #20 + #56. And there is a PR trying to fix it: #54.

Here the comment from that PR:

But I'm not sure if it's fixable without also fixing github.com's syntax highlighting. 🤔 So far this theme was built with these restrictions:

1. Keep the colors to github.com as close as possible.
2. Keep the same hue for the light and dark version.

We could disregard the two restrictions and experiment with different colors, but might be safer to initially do that as a separate theme that isn't used for Codespaces.

So yeah, we would have to diverge from the syntax highlighting on github.com or maybe better yet: Change it in the VS Code theme AND on github.com.

from github-vscode-theme.

This came up a few times.. #19 + #20 + #56. And there is a PR trying to fix it: #54.

Here the comment from that PR:

But I'm not sure if it's fixable without also fixing github.com's syntax highlighting. 🤔 So far this theme was built with these restrictions:

1. Keep the colors to github.com as close as possible.
2. Keep the same hue for the light and dark version.

We could disregard the two restrictions and experiment with different colors, but might be safer to initially do that as a separate theme that isn't used for Codespaces.

So yeah, we would have to diverge from the syntax highlighting on github.com or maybe better yet: Change it in the VS Code theme AND on github.com.

Thanks for the info. I would like to embrace the changes, both of them:D

from github-vscode-theme.