[BUG] Dark theme changes color about github-vscode-theme HOT 11 OPEN

Facing the same problem with github themes.

from github-vscode-theme.

Guys, I think I found the solution. In my case, vscode updated to the January 2024 version (1.86). I downgraded to version 1.85.1 and the colors were fixed 🎉

from github-vscode-theme.

I can't really reproduce this. 🤔 Here the steps I took:

1. Open a new file
2. Paste the below sample code
3. Safe as dart.dart
4. Toggle the theme's semanticHighlighting

class _InspectionResultState extends State<InspectionResult> {
  @override
  Widget build(BuildContext context) {
    return Container(
      width: double.infinity,
      child: Card()
    )
  }
}

semanticHighlighting: true	semanticHighlighting: false

Not noticing a difference. Is there another (dart) extension that needs to be installed?

from github-vscode-theme.

@simurai
0.1. Install Flutter and Dart VSCode plugins
0.2. Install GitHub theme VSCode plugin
0.3. Select GitHub theme for the VSCode

from github-vscode-theme.

Hmm.. installed Flutter and Dart, but still can't see a difference:

semanticHighlighting: true	semanticHighlighting: false

from github-vscode-theme.

@simurai
Just tested with the latest 'Visual Studio Code - Insiders' and the latest GitHub theme plugin, Flutter and Dart plugins are the latest as well.
Default VSCode theme:

GitHub theme - recommended - 'GitHub Dark colorblind':

from github-vscode-theme.

'GitHub Dark colorblind':

Hmm... weird. Still can't reproduce with GitHub Dark Colorblind (Beta):

from github-vscode-theme.

@simurai thanks a lot for the answer.
Could I kindly ask you to check it on Windows 11 or Windows 10 ?
I reproduced this issue on Windows 11

from github-vscode-theme.

Hi, I want to share mine as well. Looks like magic/special methods are rendered in a different color. I first thought this comes from "Pylance" extension but disabled it and the problem still exists.

Language: Python
OS: Pop!_OS 22.04 LTS x86_64
VSCode: 1.77.0
GitHub Theme: v6.3.4
Theme: "GitHub Dark Dimmed"

Photo from GitHub website:

Photo from VSCode:

And yes I tried turning off semantic highlighting, but no soccess.

"editor.semanticHighlighting.enabled": false,

Thanks.

from github-vscode-theme.

Any updates are welcome

'GitHub Dark default' theme has the same issue

from github-vscode-theme.

I mentioned #192 issue already - it was reproduced by many users but closed without any fixes.

from github-vscode-theme.