Material color property should not be restricted to enum about gokit HOT 1 CLOSED

I'd say kill it completely if moving to strings. That makes more sense.

Mike

On Tue, Sep 3, 2013 at 8:06 AM, Rhys van der Waerden <
[email protected]> wrote:

GoMaterialColorType enum is a bit misguided. Shaders can use any string as
a color variable name, so restricting the identifier to an enum is useless
for many cases. In fact many stock Unity shaders use names that are not
present in the enum (ie. "_TintColor"). Adding more elements to the enum
will not fix the problem for anyone using custom shaders with masks/toon
ramps/whatever.

People are used to supplying the full string when using Material.SetColor.
It would be idiomatic to use a string here as well.

I'll make the fix and create a pull request if people agree.

Should I support the enum for back compatability or just remove it
completely?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/29
.

from gokit.