prfalken / leonardo Goto Github PK

Hi! Making graphs, I noticed that I had two colors, "red" and "orange", and I pondered: Would the color between them be "redorange" or "orangered"? Perhaps "tangerine" or "bloodorange"? It'd be easy to tell if I knew which color standard were being used; my guesses are CSS, matplotlib, W3C, and X11. Dunno which, but we can find out!

This issue's mostly for me; I think that I can fix it by researching and documenting.

It would be nice to implement an authentication system for Leonardo, with LDAP support.

Without a license, this code is all rights reserved [0].

I recommend BSD/MIT or Apache 2.0. For example gdash is under Apache 2.0 [1].

[0] http://stackoverflow.com/a/13669816/1429452
[1] https://github.com/ripienaar/gdash/blob/master/COPYING

When I zoom in an interval, and then change to another interval, zoom is reset.

Create a nice 500 error page, and if possible display the underlying Graphite error when a graph is not valid.

This is especially a problem because the .git folder is shown. I'll send a PR with a fix.

If you click the search button without entering a search term it 500s.

http://leonardo.example.com/search/?dashboard=

It should not be allowed to search for an empty term or it should return no results.

• Calling leonardo.example.com/_dashboard/$category/$dashboard should return a list of graphs in json format with metadata (title, vtitle, etc.) and GraphiteURL.
• Calling leonardo.example.com/_graph/$category/$dashboard/$graphname should return the single graph in json format.

This is a prerequisite to allow different JS graph rendering tools such as Rickshaw or HighCharts.

When using the "Select Date" date range option on the dashboard page view, it would be useful to keep the date ranges visible after the "Show" button is clicked.

This would allow searching of different date ranges without having to re-click the "Select Date" button each time.

It would also be useful to retain the date ranges entered from the previous date range search request.

They have been written nearly at once, and the concept behind these two classes is fuzzy. a few ideas :

• extract the View class in a separate module to let routes alone
• merge the View and Leonardo class
• define a better name for the Leonardo class if keeping two classes is relevant.

I'm trying to figure out how to make a graph with mostDeviant, As described here: http://obfuscurity.com/2012/04/Unhelpful-Graphite-Tip-6

The following renders the graph but doesn't display the hostnames of the 5 lines and instead labels them as mostDeviant.

fields:
    mostDeviant:
        color: green
        field_linewidth: 2
        data: mostDeviant(5, collectd.*.load.load.shortterm)

if I set

hide_legend: false

in a graph, it won't be included because the code tries:

if properties.get("hide_legend"): url_parts.append( "hideLegend=%s" % properties["hide_legend"] )

When an individual graph is being view, it displays fixed periods. It would be useful to have another view added to this, which allows the user "zoom" in on events in the graph by use of a slide bar.

It would be useful if there was more example templates, can you post the configs for the dashboard in the pictures on the README.

I've been trying to make a graph for load to get started and I can't seem to get it working, not sure if my config is wrong or if the yaml is wrong.

Some of the code doesn't comply with PEP E501 and is somewhat difficult to read.

This is too difficult to read:

for category in [ name for name in os.listdir(self.graph_templates)
                                        if not name.startswith('.') and os.path.isdir(os.path.join(self.graph_templates, name)) ]:

I may end up cleaning up some things, so this might be more of a note to myself

Hi!

Time ago, I registered #leonardo in Freenode. Today, IRC user "vbernat" asked me to transfer the channel to this project if it's no longer being used. It is not and I would be happy to transfer it.

I just need to verify that the request from "vbernat" is in the name of the project and the Freenode nickname "julez" is a correct recipient for the channel ownership. Could you please confirm it?

Thanks.

From what I gathered so far, the url for the images is really set via JavaScript and there needs to be a div around, that has the class needed_width. There is no such div in templates/multiple.html. Thus https://github.com/PrFalken/leonardo/blob/master/leonardo/static/js/leonardo.js#L178 replaces the width with null and graphite throws an error: ValueError: invalid literal for int() with base 10: 'null'

Imho there is no way to get the correct width of the images in multiple view, because there might be any number of graphs that have to fit in one line so multiple dashboards can be compared. So maybe a default should be used if needed_width is not set.

I would love to add support of HighCharts/HighStock or D3 so that the user can choose between standard graphite PNG or HighCharts or D3.
Not sure how to do this, but it seems way more complicated that simply generate an URL as GraphiteGraph does.

Instead of little having little ugly squares visiable while the graphs load it would be nice if there was a pretty loading animation such as a spinner.

Nested menu support is needed when you have a lot of hosts. :)

Usecase below.

   LinuxTeam           (not clickable, top menu)
       LinuxLabA       (should be clickable with hostgroup specific graphs)
            - host1    (should be clickable with host specific graphs)
            - host2
            - host3
       LinuxLabB
            - host1
            - host2
       TerminalServer
            - host1
            - host2

Ideas, comments, concerns?